Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix act not locating main.js #11

Closed
wants to merge 1 commit into from

Conversation

kitsunde
Copy link
Contributor

@kitsunde kitsunde commented Jan 3, 2021

It was pretty painful trying to get yarn test to run. When running tests this happens:

[Balto/lint] ⭐  Run ./
| internal/modules/cjs/loader.js:985
|   throw err;
|   ^
|
| Error: Cannot find module '/github/workspace/balto-rubocop/main.js'
|     at Function.Module._resolveFilename (internal/modules/cjs/loader.js:982:15)
|     at Function.Module._load (internal/modules/cjs/loader.js:864:27)
|     at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:74:12)
|     at internal/main/run_main_module.js:18:47 {
|   code: 'MODULE_NOT_FOUND',
|   requireStack: []

It seems like path resolution for node-based actions got changed in https://github.com/nektos/act/releases/tag/v0.2.16 and you should now provide a path to checkout

Related:

nektos/act#228
nektos/act#371
nektos/act#185

@sheck sheck self-assigned this Jan 4, 2021
@sheck
Copy link
Member

sheck commented Jan 4, 2021

@kitsunde 👋 Thanks for taking the time to open this PR! I'm a little busy at the moment, but I'll try to take a closer look sometime soon.

@kitsunde
Copy link
Contributor Author

kitsunde commented Jan 4, 2021

That's okay, this is just working around an act issue so i could run the tests, it has no urgency to me personally and it breaks GitHub actions.

I think people are now doing env checks to install on different paths in act and GitHub to deal with it.

@sheck
Copy link
Member

sheck commented Jan 8, 2021

Which version of act do you have installed? act --version should tell you

@sheck sheck closed this Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants