Skill charges support #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…word is CHSK and is used much the same way as SK.
youbetterdont
force-pushed
the
feature/skill-charges-support
branch
from
5bd2540 to
e7b74f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for filtering items based on skill charges. The new keyword is CHSK and is used much the same way as SK.
line for readme:
CHSKkeyword. For example, to find level 2 lower resist wands, useWAND MAG CHSK91>1as the filter criteria. The skill index is the same as that used for individual skill bonuses.Edit 1:
Just thought of something. I didn’t check how the condition objects are freed. They are created with a naked new. I’ll try to remember to check this later, or just let me know if this is already handled somewhere else.
Edit 2:
I think there's a memory leak here. Doesn't seem like anything is deleting the created conditions or rules. I think we should change everything to use unique_ptr. Other option is to free stuff in UninitializeItemRules(), but it's not as clean. Considering I didn't add any new memory leak, maybe we leave this fix for another PR.