Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q: File System Shape? #104

Closed
crgardner opened this issue Dec 21, 2020 · 5 comments
Closed

Q: File System Shape? #104

crgardner opened this issue Dec 21, 2020 · 5 comments
Labels
wontfix This will not be worked on

Comments

@crgardner
Copy link

Any plans to create a File System shape?

I believe it's one of the shapes that Simon Brown shows in his presentation linked
https://c4model.com/

@adrianvlupu
Copy link
Member

Hi, I couldn't find the shape you are mentioning. I tried using a folder or a file instead of the default rectangle but it doesn't look that great.

image

@stale
Copy link

stale bot commented Feb 24, 2021

This issue has been automatically marked as stale because it has not had activity in the past 60 days. It will be closed in seven days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue has not been active for 60 days label Feb 24, 2021
@stale stale bot closed this as completed Mar 3, 2021
@Potherca Potherca added this to the v2.1.0 milestone Apr 4, 2021
@Potherca
Copy link
Member

Potherca commented May 2, 2021

Re-opening this as it is under consideration in #145

@Potherca Potherca reopened this May 2, 2021
@stale stale bot removed the stale Issue has not been active for 60 days label May 2, 2021
@Potherca Potherca modified the milestones: v2.1.0, v2.3.0 May 2, 2021
@kirchsth
Copy link
Member

@Potherca: I would remove it from v2.3.0 because I think we should not add it (and all other points are basically implemented)

@Potherca Potherca modified the milestones: v2.3.0, v2.4.0 Jun 17, 2021
@stale stale bot added the stale Issue has not been active for 60 days label Aug 16, 2021
@plantuml-stdlib plantuml-stdlib deleted a comment from stale bot Aug 17, 2021
@stale stale bot removed the stale Issue has not been active for 60 days label Aug 17, 2021
@Potherca Potherca added the not-stale Stop issue from being marked stale by bot label Aug 17, 2021
@Potherca Potherca removed this from the v2.4.0 milestone Aug 17, 2021
@Potherca Potherca added wontfix This will not be worked on and removed not-stale Stop issue from being marked stale by bot labels Aug 17, 2021
@Potherca
Copy link
Member

Based on the discussion in #145, the current mindset is to not implement a folder shape.

To summarize:

We should not add (too many) shapes, otherwise we would have to make a very generic implementation and we lose the C4 relation and create a new "Meta" notation.

As Simon Brown stated in #97

there is no "C4 model notation" [..] feel free to use whatever shapes/icons you like

Adding the shape is only half of the solution. To my mind, we should not be adding shapes but Container, Components, etc.

So, unless some very convincing arguments are posted, this issue will not be re-opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
Status: Done
Development

No branches or pull requests

4 participants