Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing a v2.3.0 release #165

Closed
kirchsth opened this issue Jun 28, 2021 · 6 comments
Closed

Preparing a v2.3.0 release #165

kirchsth opened this issue Jun 28, 2021 · 6 comments
Assignees
Milestone

Comments

@kirchsth
Copy link
Member

Hi @Potherca, @adrianvlupu, @IOrlandoni, @michiel and @stawirej:

Can we create a new v2.3.0 with all open pull requestes?

I have an updated structurizr/dotnet-extsions C4PlantUmlWriter and would prefere to use a official include with all available features.

Thank you and best regards
Helmut

PS.: Based on an official Structurizr v1.0.0 model it generated pictures (with v2.2.0) like

grafik

and with v2.3.0 like

grafik

@Potherca
Copy link
Member

I plan on creating a 2.3 release this coming weekend, with all currently open MRs.

@Potherca Potherca added this to the v2.3.0 milestone Jun 29, 2021
@kirchsth
Copy link
Member Author

thank you

@Potherca
Copy link
Member

Potherca commented Jul 2, 2021

Comment moved over from #161:

@Potherca: I would create a new release with following Issues/PR:
solved issues: #159,#157,#149,#146,#145,#139,#134,#21,#12
PRs: #161,#160,#158,#150,#147,#143,#141,#59

I agree with the outline stated above. I'll make a v2.3.0 branch to see if everything can easily be merge without to many conflicts, to save contributors the effort of having to keep updating/merging/rebasing their changes.

I also plan to make a develop branch, to merge upcoming MR into sooner, rather than running into a situation like this again. where we have MR from across 6 months that need integrating.

@Potherca Potherca changed the title Can we create a new v2.3.0 release that it can be used in "Structurizr/dotnet-extensions"? Preparing a v2.3.0 release Jul 2, 2021
@Potherca Potherca self-assigned this Jul 2, 2021
@Potherca Potherca pinned this issue Jul 2, 2021
@Potherca
Copy link
Member

Potherca commented Jul 4, 2021

All branches could be merged to the same branch without conflicts or issues. Will now commence merging all MRs.
All branches merged.

@Potherca Potherca unpinned this issue Jul 4, 2021
@Potherca
Copy link
Member

Potherca commented Jul 4, 2021

All done! Release v2.3 is now a fact!

@Potherca Potherca closed this as completed Jul 4, 2021
@kirchsth
Copy link
Member Author

kirchsth commented Jul 4, 2021

@Potherca, Thank you

Can you
a) update the moved comment and remove all issues which are not part of it

(156 could be obsolete as soon it is merged into PlantUML)
NOT included: 155, 154, 148, 85
Rejected?:104

b) add/link/close #159, #157 and #149 too (corresponding implementations were part of the PRs #160, #158 and #150)

BR
Helmut

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants