Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persons can be displayed as portraits #139

Closed
kirchsth opened this issue Apr 8, 2021 · 2 comments · Fixed by #141
Closed

Persons can be displayed as portraits #139

kirchsth opened this issue Apr 8, 2021 · 2 comments · Fixed by #141
Milestone

Comments

@kirchsth
Copy link
Member

kirchsth commented Apr 8, 2021

Based on PR #49 it should be possible to display persons with a portrait instead of a rectangle.
Therefore a new SHOW_PERSON_PORTRAIT() is added that portraits can be activated.

  • SHOW_PERSON_PORTRAIT(): activates portrait outline instead of a rectangle

Based on the new available features a new PR will be created (#49 does not match anymore)

@startuml
' convert it with additional command line argument -DRELATIVE_INCLUDE="." to use locally
!if %variable_exists("RELATIVE_INCLUDE")
  !include ./../C4_Deployment.puml
!else
  !include https://raw.githubusercontent.com/kirchsth/C4-PlantUML/extended/C4_Deployment.puml
!endif


!$COLOR_A_5 = "#7f3b08"
!$COLOR_A_1 = "#fee0b6"
!$COLOR_NEUTRAL = "#f7f7f7"
UpdateElementStyle("person", $bgColor=$COLOR_A_5, $fontColor=$COLOR_NEUTRAL, $borderColor=$COLOR_A_1, $shadowing="true")

SHOW_PERSON_PORTRAIT()

' default header Property, Value
AddProperty("Name", "Flash")
AddProperty("Organization", "Zootopia")
AddProperty("Tool", "Internet Explorer 7.0")
Person(personAlias, "Label", "Optional Description (with default property header)")
Person(personAlias1, "Simple")
Person(personAlias2, "Simple with sprite", $sprite="person2")
AddProperty("Name", "Flash")
AddProperty("Organization", "Zootopia")
AddProperty("Tool", "Internet Explorer 7.0")
Person_Ext(personAliasExt, "Label Ext", "Optional Description (with default property header)")
Person_Ext(personAliasExt1, "Simple Ext")
Person_Ext(personAliasExt2, "Simple Ext with sprite", $sprite="person2")

SHOW_LEGEND()
@enduml

SHOW_PERSON_PORTRAIT() Sample

kirchsth added a commit to kirchsth/C4-PlantUML that referenced this issue Apr 8, 2021
…nIconic and tags (7 - update sample with scaled sprites)

plantuml-stdlib#49,  plantuml-stdlib#139: Persons can be displayed as portraits - SHOW_PERSON_PORTRAIT()
@Potherca Potherca modified the milestones: v2.2.0, v2.3.0 Apr 11, 2021
@stale stale bot added the stale Issue has not been active for 60 days label Jun 10, 2021
@kirchsth
Copy link
Member Author

@Potherca: time for a new release?
related to #85: Maybe the review rules should be changed (only one reviewer required)

@stale stale bot removed the stale Issue has not been active for 60 days label Jun 10, 2021
@Potherca Potherca added the not-stale Stop issue from being marked stale by bot label Jun 13, 2021
@plantuml-stdlib plantuml-stdlib deleted a comment from stale bot Jun 13, 2021
@Potherca
Copy link
Member

I was hoping to get more changes in and release v2.3 but I am indeed stuck waiting for reviewers 😞

Potherca added a commit that referenced this issue Jul 4, 2021
#49, #139: Persons can be displayed as portraits - SHOW_PERSON_PORTRAIT()
@Potherca Potherca removed the not-stale Stop issue from being marked stale by bot label Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants