-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enables theme support #295
Enables theme support #295
Conversation
Another open question is the integration in the stdlib, details see https://forum.plantuml.net/17601/how-where-should-integrate-themes-into-the-plantuml-stdlib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some minor wording issues and a question or two...
Should we do "something" regarding defaults? I was looking at the current default settings:
And I was thinking, the "theme" can be greatly simplified by providing a few Just thinking out loud though. |
… - add themes, fix PR findings)
…a - update themes, fix PR findings)
… - update themes/add overview, fix PR findings)
@Potherca: related to "dependent color/size":
|
… - extract all constant values)
I tried to introduce a default font size as starting point (that we can calculate all other sizes based on it) but If you review is OK I would merge it and would even create a new release 2.6 out of it (and move all other open into a backlog release?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Work!
Regarding:
I'm all for it! Usually I'd say bump all "documentation" issues to a 2.6.1 (so we can follow up with writing some prose and docs but no code changes) and everything else to v2.7 but based on #293, do we want to make a |
Thanks for adding theme support! I've published a handful of themes based on ColorBrewer and Seaborn palettes to https://github.com/mweagle/C4-PlantUML-Themes if you're interested in including/linking. Thanks again. |
related to #245 and #291,
C4-PlantUML is prepared that themes can be used (all internal variables are only set, if they are not defined in an e.g. theme). This enables custom themes like below
The sample theme C4_FirstTest is stored in the themes folder.
The list of all changeable variables is documented in the Themes.md.
The MR is basically full working (it can be checked via my extended branch), but atm the documentation is not finished and I have no useful theme therefore it is a draft.
@Potherca, @manonmichel, @ProtoSlayer: it should fix #245 and #291. Can you please check if everything is OK or if I have missed something.
AND if you have a nice theme (best case based on an existing theme) maybe you want to publish it that it can be included.
BR Helmut