Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update examples #61

Merged
merged 3 commits into from
Mar 6, 2023
Merged

Update examples #61

merged 3 commits into from
Mar 6, 2023

Conversation

sakirtemel
Copy link
Collaborator

Why

Towards fixing #51

What

  • Store each file separately to avoid issue of colliding on multiple diagrams
  • Add second diagram in asciidoctor to reproduce the bug
  • Use npm package instead of local dirrectory

@sakirtemel sakirtemel merged commit e0f22f1 into main Mar 6, 2023
@sakirtemel sakirtemel deleted the update-examples branch March 6, 2023 22:45
@sakirtemel sakirtemel had a problem deploying to github-pages-mirror-for-previews March 6, 2023 22:45 — with GitHub Actions Error
@sakirtemel sakirtemel temporarily deployed to github-pages-mirror-for-previews March 6, 2023 22:45 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

Preview URL is removed automatically after the PR is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sakirtemel