Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SSL/TLS #32

Open
KISSMonX opened this issue Nov 10, 2019 · 11 comments
Open

Add support for SSL/TLS #32

KISSMonX opened this issue Nov 10, 2019 · 11 comments
Labels
enhancement New feature or request

Comments

@KISSMonX
Copy link

KISSMonX commented Nov 10, 2019

Thank You。

@plapointe6
Copy link
Owner

Unfortunatly, there is no SSL/TLS support yet with this lib. I will add that to the TODO list. Here is a PubSubClient issue discussing how you can achieve this with the PubSubClient lib : knolleary/pubsubclient#462

@plapointe6 plapointe6 added the enhancement New feature or request label Nov 12, 2019
@plapointe6 plapointe6 changed the title How to support TLS? Add support for SSL/TLS Nov 12, 2019
@KISSMonX
Copy link
Author

Thank you for your reply, happy to look forward to the arrival of new features. 😊

@steros76
Copy link

This feature would be very welcome!
I hope it's on first line of your todo list... :)

@cstanke
Copy link

cstanke commented Dec 4, 2019

Yes please! Yes please!

@nopap
Copy link

nopap commented Apr 6, 2020

Hi,
Updating the library is in fact quite simple to make it work in TLS.
It's probably quick and dirty, but works for me.

Change the include from
#include <WiFiClient.h> to #include <WiFiClientSecure.h>

Then the declaration:
WiFiClient mWifiClient; to WiFiClientSecure mWifiClient;
and move it to public.

Then the library will use the secure library, and give you access from your code to the mWifiClient object where you'll be able to change settings and set properties such as:

client.mWifiClient.setFingerprint(fingerprint);   // <-- Set the SHA1 fingerprint to verify remote server
  // Alternative: client.mWifiClient.setInsecure();

Works for my mosquitto in mqtts.

@codersaur
Copy link

+1. Please add support for TLS (ideally server and client certs). Thanks.

@paviro
Copy link

paviro commented Jan 17, 2021

I would also really appreciate SSL support for HASS-YAAP :)

@cd334
Copy link

cd334 commented Dec 30, 2022

+1. Please add support for TLS! Thanks!

@zouje
Copy link

zouje commented Jan 14, 2023

+1 please

@EdJoPaTo
Copy link
Contributor

There is no need in adding "+1" comments. That does not change anything. You could instead provide Pull Requests. ;)

@plapointe6
Copy link
Owner

plapointe6 commented Jan 15, 2023

If someone takes time to implement this, I will take the time to review and test. However, I don't think I will implement this by myself. I work on this lib for free and I don't have as many free time as before. Also, as almost all of my home automation devices are now working on ZigBee, I don't use this lib as much as before. It became hard for me to test new functionnalities. Thank you for your comprehension.

Rosen01 added a commit to Rosen01/EspMQTTClient that referenced this issue Jan 21, 2023
Answer to issue plapointe6#32.

Signed-off-by: Daniel Rosengarten <github@praetorians.be>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

10 participants