Put debug messages behind a define guard to reduce binary size #135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've put all Serial.print(s) behind a define guard (ENABLE_DEBUG_MESSAGES). When enabled, the debug messages take up 1448 bytes which is ~2% of the variables and constants section when compiling.
Here's the output when compiling with
ENABLE_DEBUG_MESSAGES
:Here's the output when compiling without
ENABLE_DEBUG_MESSAGES
:NOTE: These logs are valid when compiling for the ESP8266 platform. In other models the percentages may differ.
NOTE: These logs were generated when compiling the SimpleMQTTClient example.