Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the hostname not getting applied on ESP32 since
WiFi.mode()
was called before setting the hostname.Explanation
Taking a look at the WiFi library,
you can see setHostname method calls set_esp_netif_hostname which sets the
default_hostname
variable with the provided hostname.This variable is read only by get_esp_netif_hostname which gets called in mode and only when the mode is changed to
WIFI_MODE_STA
refTL;DR
WiFi.setHostname()
to set internal variabledefault_hostname
with desired hostname.WiFi.mode()
with parameterWIFI_STA
which will apply the hostname.Tested and working on ESP32 (Arduino-ESP32 v2.0.17) and no breaking changes found on ESP8266.