[WIP] Board Base (Typescript) #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monkeyci
reviewed
Jul 21, 2017
app/javascript/custom.d.ts
Outdated
| @@ -0,0 +1,9 @@ | |||
| declare module "*.vue" { | |||
| import Vue from 'vue' | |||
| export default typeof Vue | |||
app/javascript/custom.d.ts
Outdated
| @@ -0,0 +1,9 @@ | |||
| declare module "*.vue" { | |||
| import Vue from 'vue' | |||
app/javascript/custom.d.ts
Outdated
| export default typeof Vue | ||
| } | ||
|
|
||
| declare module "*.svg" { |
app/javascript/custom.d.ts
Outdated
| @@ -0,0 +1,9 @@ | |||
| declare module "*.vue" { | |||
|
excelente... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lo mismo que #14 pero en TypeScript.
Me gusta como se ve pero no sé si haría el cambio ahora, se viene soporte aun mejor de TS en Vue vuejs/vue#5887 (ahora hay que usar vue-class-component para resolver un par de problemas).
Lo otro es que no hay soporte de tslint dentro de archivos *.vue palantir/tslint#2099. Agregué tslint a webpack y se pueden ver los errores ahí pero no es la mejor solución.
Dejaría este PR para tener una base cuando migremos pero no lo mergearía/adaptaría hasta que, por lo menos, el primer tema esté resuelto.