Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

feat(ci): Spin crc-cloud in CI #93

Merged
merged 2 commits into from
Feb 20, 2023
Merged

feat(ci): Spin crc-cloud in CI #93

merged 2 commits into from
Feb 20, 2023

Conversation

lmilbaum
Copy link
Contributor

@lmilbaum lmilbaum commented Feb 13, 2023 •
edited
Loading

No description provided.

@lmilbaum lmilbaum self-assigned this Feb 13, 2023
@lmilbaum lmilbaum changed the title Merge pull request #92 from platform-engineering-org/renovate/all-min… crc-cloud Feb 13, 2023
@lmilbaum lmilbaum changed the title crc-cloud feat(ci): Spin crc-cloud in CI Feb 13, 2023
@lmilbaum lmilbaum force-pushed the crc-cloud branch 3 times, most recently from fbbbb6a to 640d589 Compare February 13, 2023 14:50
@lmilbaum lmilbaum mentioned this pull request Feb 13, 2023
Merged
@lmilbaum lmilbaum force-pushed the crc-cloud branch 17 times, most recently from 9c8d0d3 to 6648d67 Compare February 16, 2023 12:00
@lmilbaum lmilbaum mentioned this pull request Feb 16, 2023
Closed
@adrianriobo adrianriobo force-pushed the crc-cloud branch 2 times, most recently from d80f3be to 138c8db Compare February 17, 2023 08:27
@lmilbaum lmilbaum marked this pull request as ready for review February 19, 2023 13:00
@adrianriobo
Copy link
Contributor

adrianriobo commented Feb 20, 2023 •
edited
Loading

I think this should be solved crc-org/crc-cloud#45 , as for the PoC I expect at least to being able to connect to cluster out of the box.

@adrianriobo adrianriobo mentioned this pull request Feb 20, 2023
Closed
@lmilbaum
Copy link
Contributor Author

lmilbaum commented Feb 20, 2023 •
edited
Loading

I think this should be solved crc-org/crc-cloud#45 , as for the PoC I expect at least to being able to connect to cluster out of the box.

Thanks for your feedback. Does that block this PR or we can merge it and handle the outcome when crc-org/crc-cloud#45 is solved?

@lmilbaum
Copy link
Contributor Author

I'm going ahead an merging this PR. We can handle changes in future PRs.

@lmilbaum lmilbaum merged commit c3fb0b0 into main Feb 20, 2023
@lmilbaum lmilbaum deleted the crc-cloud branch February 20, 2023 16:47
@adrianriobo
Copy link
Contributor

yeah sorry for late reply, we were missing the crc-clud action green pass...it was showing green but checking the logs there was an issue with the pullsecret. @yerdreic added PS_64 secret and now we have a full green pass 👏 . Still missing the permissions on the output files but definitely this is well merged

@lmilbaum
Copy link
Contributor Author

Where is the PS_64 secret is tracked?

@adrianriobo
Copy link
Contributor

adrianriobo commented Feb 21, 2023 •
edited
Loading

We added it manually yesterday as a repo secret, just to see if we got a green pass, you can now track is as you did with others (I asked @yerdreic to add it as I do not have rights to handle settings)

@lmilbaum
Copy link
Contributor Author

We added it manually yesterday as a repo secret, just to see if we got a green pass, you can now track is as you did with others (I asked @yerdreic to add it as I do not have rights to handle settings)

Thanks @adrianriobo. I'll ask @yerdreic to document the workaround.

@yerdreic
Copy link
Contributor

@lmilbaum Sure. Is there an official doc in which we document kind of things?

@lmilbaum
Copy link
Contributor Author

README file

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yerdreic yerdreic Awaiting requested review from yerdreic

@adrianriobo adrianriobo Awaiting requested review from adrianriobo

Assignees

@lmilbaum lmilbaum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lmilbaum @adrianriobo @yerdreic