Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/icon font enum #53

Merged
merged 3 commits into from
Feb 7, 2022
Merged

Feat/icon font enum #53

merged 3 commits into from
Feb 7, 2022

Conversation

Will-PlatformBuilders
Copy link
Contributor

@Will-PlatformBuilders Will-PlatformBuilders commented Feb 7, 2022

O que foi feito? 📝

adiciona enum dos tipos de font dos icones e atualiza o nome das fontes no icon set

Motivo

o iconSet recebia os tipos "light, regular, solid" mas a tipagem sugeria "fa-light, fa-regular, fa-solid"

Screenshots ou GIFs 📸

image

Tipo de mudança 🏗

  • Nova feature (mudança non-breaking que adiciona uma funcionalidade)
  • Bug fix (mudança non-breaking que conserta um problema)
  • Refactor (mudança non-breaking que melhora o código ou débito técnico)
  • Chore (nenhuma das anteriores, como upgrade de libs)
  • Breaking change 🚨

Checklist 🧐

  • Testado no iOS
  • Testado no Android

Copy link
Contributor

@ammichael ammichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Will-PlatformBuilders muito boa! 👏

@ammichael ammichael merged commit e18f619 into master Feb 7, 2022
@ammichael ammichael deleted the feat/iconFont-enum branch February 7, 2022 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants