Make ESC great again

plausible · Sep 13, 2023 · 0f42b57 · 0f42b57
1 parent 7960637
commit 0f42b57
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/assets/js/liveview/suggestions_dropdown.js b/assets/js/liveview/suggestions_dropdown.js
@@ -41,7 +41,9 @@ let suggestionsDropdown = function(id) {
       return currentFocus - 1 >= this.leastFocusableIndex() ? currentFocus - 1 : this.maxFocusableIndex()
     },
     close(e) {
-      if (this.isOpen) {
+      // Pressing Escape should not propagate to window,
+      // so we'll only close the suggestions pop-up
+      if (this.isOpen && e.key === "Escape") {
         e.stopPropagation()
       }
       this.isOpen = false