Skip to content

Commit

Permalink
Revert "Make escape work for closing combobox suggestions"
Browse files Browse the repository at this point in the history
This reverts commit 306866d.

@ukutaht unfortunately this makes it impossible to select
an suggestion.
  • Loading branch information
aerosol committed Sep 13, 2023
1 parent 306866d commit 4844857
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions assets/js/liveview/suggestions_dropdown.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,7 @@ let suggestionsDropdown = function(id) {
const currentFocus = this.focus
return currentFocus - 1 >= this.leastFocusableIndex() ? currentFocus - 1 : this.maxFocusableIndex()
},
close(e) {
if (this.isOpen) {
e.stopPropagation()
}
this.isOpen = false
},
close() { this.isOpen = false },
select() {
this.$refs[`dropdown-${this.id}-option-${this.focus}`]?.click()
this.close()
Expand Down

0 comments on commit 4844857

Please sign in to comment.