-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow optional IPv6 for clickhouse repo #2970
Conversation
This ought to replace the ungodly |
I've never actually written in this language before, so which options do you want me to use? |
I think get_var_from_path_or_env(config_dir, "ECTO_CH_IPV6", "false")
|> String.to_existing_atom() that Uku suggested would be the most consistent. Let's go with that. |
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Got it, thanks for the pointers! |
BundleMonUnchanged files (7)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
Ah I see this missed 2.0, shame. Was anything else needed? |
* Allow optional IPv6 for clickhouse repo Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space> * remove trailing comma --------- Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space> Co-authored-by: ruslandoga <rusl@n-do.ga>
Changes
Adds optional support for connect to clickhouse over ipv6. Same as #1661, but for clickhouse.
Tests
Changelog
Documentation
Dark mode