not ready for $

plausible · Sep 6, 2024 · 424c65a · 424c65a
1 parent f278c04
commit 424c65a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/lib/ch/types.ex b/lib/ch/types.ex
@@ -480,8 +480,9 @@ defmodule Ch.Types do
   defguardp is_alpha(a) when (a >= ?a and a <= ?z) or (a >= ?A and a <= ?Z)
   defguardp is_numeric(char) when char >= ?0 and char <= ?9
 
+  # TODO add ?$
   defp decode_identifier(<<a, rest::bytes>>, len, original, stack, acc)
-       when is_alpha(a) or is_numeric(a) or a == ?_ or a == ?$ do
+       when is_alpha(a) or is_numeric(a) or a == ?_ do
     decode_identifier(rest, len + 1, original, stack, acc)
   end
 

diff --git a/test/ch/query_test.exs b/test/ch/query_test.exs
@@ -103,7 +103,8 @@ defmodule Ch.QueryTest do
       assert [[{"Hello", 123}]] = Ch.query!(conn, "select ('Hello', 123)").rows
       assert [[{"Hello", 123}]] = Ch.query!(conn, "select ('Hello' as a, 123 as b)").rows
       assert [[{"Hello", 123}]] = Ch.query!(conn, "select ('Hello' as a_, 123 as b)").rows
-      assert [[{"Hello", 123}]] = Ch.query!(conn, "select ('Hello' as a$, 123 as b)").rows
+      # TODO
+      # assert [[{"Hello", 123}]] = Ch.query!(conn, "select ('Hello' as a$, 123 as b)").rows
     end
 
     test "decode network types", %{conn: conn} do