Catch all errors in connect/2 (#209)

* add failing test

* mark test slow

* sleep less

* add fix

* changelog

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## Unreleased
+
+- catch all errors in `connect/1` to avoid triggering Supervisor https://github.com/plausible/ch/pull/209
+
 ## 0.2.8 (2024-09-06)
 
 - support named tuples https://github.com/plausible/ch/pull/197

lib/ch/connection.ex

@@ -50,6 +50,8 @@ defmodule Ch.Connection do
           {:error, reason}
       end
     end
+  catch
+    _kind, reason -> {:error, reason}
   end
 
   @impl true

test/ch/connect_test.exs

@@ -0,0 +1,22 @@
+defmodule Ch.ConnectTest do
+  use ExUnit.Case
+  import ExUnit.CaptureLog
+
+  @tag :slow
+  test "retries to connect even with exceptions" do
+    # See https://github.com/plausible/ch/issues/208
+    bad_transport_opts = [sndbuf: nil]
+
+    logs =
+      capture_log(fn ->
+        {:ok, conn} =
+          Ch.start_link(database: Ch.Test.database(), transport_opts: bad_transport_opts)
+
+        :timer.sleep(100)
+
+        assert Process.alive?(conn)
+      end)
+
+    assert logs =~ "failed to connect: ** (ArgumentError) argument error"
+  end
+end