Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add erlang 27 to ci #174

Merged
merged 1 commit into from
May 26, 2024
Merged

add erlang 27 to ci #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/bench.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,10 @@ jobs:

strategy:
matrix:
elixir: ["1.16"]
otp: ["26"]
clickhouse: ["latest"]
# TODO
elixir: [v1.17.0-rc.0]
otp: [27]
clickhouse: [latest]

services:
clickhouse:
Expand Down
38 changes: 22 additions & 16 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,22 +14,27 @@ jobs:

strategy:
matrix:
elixir: ["1.14", "1.15", "1.16"]
otp: ["25", "26"]
clickhouse: ["latest"]
timezone: ["UTC"]
elixir: [1.14, 1.15, 1.16]
otp: [25, 26]
clickhouse: [latest]
timezone: [UTC]
include:
- elixir: "1.16"
otp: "26"
clickhouse: "latest"
timezone: "Europe/Berlin"
- elixir: 1.16
otp: 26
clickhouse: latest
timezone: Europe/Berlin
# TODO
- elixir: v1.17.0-rc.0
otp: 27
clickhouse: latest
timezone: UTC
# Plausible
# - https://github.com/plausible/analytics/blob/master/.tool-versions
# - https://github.com/plausible/analytics/blob/master/.github/workflows/elixir.yml
- elixir: "1.16.0"
otp: "26.2.1"
clickhouse: "24.3.3.102"
timezone: "UTC"
- elixir: 1.16.0
otp: 26.2.1
clickhouse: 24.3.3.102
timezone: UTC

services:
clickhouse:
Expand Down Expand Up @@ -67,12 +72,13 @@ jobs:
- run: mix test --include slow

format:
runs-on: ubuntu-latest
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v4
- uses: erlef/setup-beam@v1
with:
elixir-version: "1"
otp-version: "26"
# TODO
elixir-version: v1.17.0-rc.0
otp-version: 27
- run: elixir -v
- run: mix format --check-formatted
2 changes: 1 addition & 1 deletion test/ch/query_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ defmodule Ch.QueryTest do
test "decoded binaries copy behaviour", %{conn: conn} do
text = "hello world"
assert [[bin]] = Ch.query!(conn, "SELECT {$0:String}", [text]).rows
assert :binary.referenced_byte_size(bin) == byte_size(text)
assert :binary.referenced_byte_size(bin) == :binary.referenced_byte_size("hello world")
Copy link
Contributor Author

@ruslandoga ruslandoga May 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like OTP-27 over-allocates memory for small binaries, so this test had to be updated since referenced byte size for "hello world" is now 88 bytes instead of 11.


# For OTP 20+ refc binaries up to 64 bytes might be copied during a GC
text = String.duplicate("hello world", 6)
Expand Down
Loading