Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ply loading fix #7110

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Ply loading fix #7110

merged 1 commit into from
Nov 13, 2024

Conversation

slimbuck
Copy link
Member

Always remember to catch correctly.

The initial fetch call was not wrapped in a catch, which would never error on the asset.

@slimbuck slimbuck added the bug label Nov 13, 2024
@slimbuck slimbuck requested a review from a team November 13, 2024 13:39
@slimbuck slimbuck self-assigned this Nov 13, 2024
@slimbuck slimbuck merged commit 5574db2 into playcanvas:main Nov 13, 2024
8 checks passed
@slimbuck slimbuck deleted the ply-fix branch November 13, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

Assignees

@slimbuck slimbuck

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slimbuck @willeastcott