Use latest netty-reactive-streams version, ahc comes with outdated one #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkurz
force-pushed
the
netty-reactive-streams-latest
branch
from
072fb94
to
d5da1fb
Compare
|
@Mergifyio backport 2.2.x 3.0.x |
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest AsyncHttpClient v2 (currently 2.12.3) comes with an outdated netty-reactive-streams dependency: 2.0.4.
Meanwhile we are on 2.0.12, which besides upgrading netty to a very recent version, also brings some fixes:
playframework/netty-reactive-streams@netty-reactive-streams-parent-2.0.4...netty-reactive-streams-parent-2.0.12
However, I will not include this PR right now in the next play-ws patch release, because I am not sure if such an upgrade would cause problems (specially because netty will be bumped from 4.1.43 to 4.1.104 which is, for netty, quite a big jump.
I keep this as a draft for later, as a reminder...