Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI with GitHub Actions (using playframework/.github) #483

Merged
merged 9 commits into from
Apr 14, 2022

Conversation

tototoshi
Copy link
Member

@tototoshi tototoshi commented Jan 28, 2022

This p-r is another version of #477 .

@tototoshi tototoshi changed the title GitHub actions ci reusable CI with GitHub Actions Jan 28, 2022
@tototoshi tototoshi marked this pull request as draft January 28, 2022 13:39
@tototoshi tototoshi force-pushed the github-actions-ci-reusable branch 3 times, most recently from b8ac1d5 to e234a18 Compare January 28, 2022 13:51
@tototoshi tototoshi changed the title CI with GitHub Actions CI with GitHub Actions (using ihostage/.github) Jan 28, 2022
@tototoshi tototoshi force-pushed the github-actions-ci-reusable branch 2 times, most recently from 8f6f231 to a3cdb2b Compare January 28, 2022 13:56
@tototoshi tototoshi changed the title CI with GitHub Actions (using ihostage/.github) CI with GitHub Actions (using playframework/.github) Feb 3, 2022
@tototoshi tototoshi marked this pull request as ready for review February 3, 2022 14:19
tototoshi and others added 8 commits April 14, 2022 15:16
Replaced the existing Travis configuration with the GitHub Actions configuration.
I used the play-json configuration as a reference, especially for publish.yml.
I've confirmed that the validation and testing work, but I haven't been able to confirm that the release works.

Notifications to Gitter have not been migrated. (I wonder if this Gitter channel is still active?)
@mkurz mkurz force-pushed the github-actions-ci-reusable branch from c5cd6a4 to df9eea9 Compare April 14, 2022 13:47
@mkurz
Copy link
Member

mkurz commented Apr 14, 2022

Thanks @tototoshi!
I refactored the yml a bit and made sure it is up to date.

@mkurz
Copy link
Member

mkurz commented Apr 14, 2022

Also @tototoshi I am going to merge that right now, please review anyway however and let me know if I am missing something. Thanks!

@mkurz mkurz merged commit dabf555 into playframework:main Apr 14, 2022
@mkurz mkurz mentioned this pull request Apr 14, 2022
@mkurz
Copy link
Member

mkurz commented Apr 14, 2022

Nice thing we now have snapshots published, so you can use them to try out the Scala 3 artifacts:
https://oss.sonatype.org/content/repositories/snapshots/com/typesafe/play/ (grep for twirl)
You just need to add

resolvers += Resolver.sonatypeRepo("snapshots")

@ihostage ihostage added this to the 1.6.0 milestone Apr 14, 2022
@tototoshi
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants