style: Enforce mypy no-implicit-optional setting #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
playpauseandstop
added
style
Which has been introduced in `mypy==0.981` and enforce proper type annotations for args / kwargs with default `None` value.
playpauseandstop
force-pushed
the
style/mypy-no-implicit-optional
branch
from
b7ccf3d
to
af644db
Compare
Merged
badabump-release-bot bot
pushed a commit
that referenced
this pull request
Oct 23, 2022
Other: ------ - Sync common project files (#119) - (**docs**) Bump requirements for docs (#121) - Use poetry 1.2.0 for managing project dependencies (#122) - Fix read the docs configuration (#124) - Tell poetry to not create virtual envs at read the docs (#125) - Install project and docs deps on post install job (#126) - Do not expect to fail on Python 3.11 (#123) - (**deps**) bump peter-evans/create-pull-request from 4.0.4 to 4.1.2 (#128) - Sync common project files (#130) - Update Python dev version to 3.10.8 (#131) - Enforce mypy no-implicit-optional setting (#132) - Integrate no-optional pre-commit hook (#133)
playpauseandstop
added a commit
that referenced
this pull request
Oct 23, 2022
Other: ------ - Sync common project files (#119) - (**docs**) Bump requirements for docs (#121) - Use poetry 1.2.0 for managing project dependencies (#122) - Fix read the docs configuration (#124) - Tell poetry to not create virtual envs at read the docs (#125) - Install project and docs deps on post install job (#126) - Do not expect to fail on Python 3.11 (#123) - (**deps**) bump peter-evans/create-pull-request from 4.0.4 to 4.1.2 (#128) - Sync common project files (#130) - Update Python dev version to 3.10.8 (#131) - Enforce mypy no-implicit-optional setting (#132) - Integrate no-optional pre-commit hook (#133) Co-authored-by: playpauseandstop <playpauseandstop@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which has been introduced in
mypy==0.981and enforce proper type annotations for args / kwargs with defaultNonevalue.