fix: Escape backticks when setting output at GitHub Actions #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply same logic as for escaping `%`, `\n`, `\r`, but now for escaping backticks itself. It also might be useful to escape `$`, to avoid bash variable substitution, so add them to escape list as well. Fixes: #63
badabump-release-bot bot
pushed a commit
that referenced
this pull request
May 12, 2021
Features: --------- - [#34] Put refactor commits into separate section (#58) Fixes: ------ - [#64] Support pre-releases with multiple digits (#66) - [#63] Escape backticks when setting output at GitHub Actions (#67) Other: ------ - (**deps-dev**) Bump coverage from 5.3.1 to 5.4 (#47) - (**deps-dev**) Bump pytest from 6.2.1 to 6.2.2 (#50) - (**deps-dev**) Bump pytest-cov from 2.10.1 to 2.11.1 (#49) - (**deps-dev**) Bump time-machine from 1.3.0 to 2.0.1 (#48) - (**deps**) Bump peter-evans/create-pull-request from v3.6.0 to v3.8.0 (#51) - Bump Python dev version to 3.9.2 (#57) - (**deps**) Bump actions/cache from v2.1.3 to v2.1.4 (#55) - (**deps**) Bump pypa/gh-action-pypi-publish from v1.4.1 to v1.4.2 (#54) - (**deps**) Bump peter-evans/create-pull-request from v3.8.0 to v3.8.2 (#56) - Update to Python 3.9.4 (#59) - (**deps**) Bump actions/setup-python from v2.2.1 to v2.2.2 (#60) - (**deps**) Bump actions/cache from v2.1.4 to v2.1.5 (#61) - (**deps**) Bump pre-commit/action from v2.0.0 to v2.0.3 (#62) - Update Python dev version to 3.9.5 (#65)
Merged
playpauseandstop
added a commit
that referenced
this pull request
May 12, 2021
Now `badabump` escapes backticks in release notes, which allows to put
code blocks in GitHub Releases description, using standard Markdown syntax,
```python
def new_release() -> str:
return "It is working!"
```
Features:
---------
- [#34] Put refactor commits into separate section (#58)
Fixes:
------
- [#64] Support pre-releases with multiple digits (#66)
- [#63] Escape backticks when setting output at GitHub Actions (#67)
Other:
------
- (**deps-dev**) Bump coverage from 5.3.1 to 5.4 (#47)
- (**deps-dev**) Bump pytest from 6.2.1 to 6.2.2 (#50)
- (**deps-dev**) Bump pytest-cov from 2.10.1 to 2.11.1 (#49)
- (**deps-dev**) Bump time-machine from 1.3.0 to 2.0.1 (#48)
- (**deps**) Bump peter-evans/create-pull-request from v3.6.0 to v3.8.0 (#51)
- Bump Python dev version to 3.9.2 (#57)
- (**deps**) Bump actions/cache from v2.1.3 to v2.1.4 (#55)
- (**deps**) Bump pypa/gh-action-pypi-publish from v1.4.1 to v1.4.2 (#54)
- (**deps**) Bump peter-evans/create-pull-request from v3.8.0 to v3.8.2 (#56)
- Update to Python 3.9.4 (#59)
- (**deps**) Bump actions/setup-python from v2.2.1 to v2.2.2 (#60)
- (**deps**) Bump actions/cache from v2.1.4 to v2.1.5 (#61)
- (**deps**) Bump pre-commit/action from v2.0.0 to v2.0.3 (#62)
- Update Python dev version to 3.9.5 (#65)
Co-authored-by: playpauseandstop <playpauseandstop@users.noreply.github.com>
badabump-release-bot bot
pushed a commit
that referenced
this pull request
May 12, 2021
Features: --------- - [#34] Put refactor commits into separate section (#58) Fixes: ------ - [#64] Support pre-releases with multiple digits (#66) - [#63] Escape backticks when setting output at GitHub Actions (#67) - [#63] Do not escape backticks & shell vars (#70) Other: ------ - (**deps-dev**) Bump coverage from 5.3.1 to 5.4 (#47) - (**deps-dev**) Bump pytest from 6.2.1 to 6.2.2 (#50) - (**deps-dev**) Bump pytest-cov from 2.10.1 to 2.11.1 (#49) - (**deps-dev**) Bump time-machine from 1.3.0 to 2.0.1 (#48) - (**deps**) Bump peter-evans/create-pull-request from v3.6.0 to v3.8.0 (#51) - Bump Python dev version to 3.9.2 (#57) - (**deps**) Bump actions/cache from v2.1.3 to v2.1.4 (#55) - (**deps**) Bump pypa/gh-action-pypi-publish from v1.4.1 to v1.4.2 (#54) - (**deps**) Bump peter-evans/create-pull-request from v3.8.0 to v3.8.2 (#56) - Update to Python 3.9.4 (#59) - (**deps**) Bump actions/setup-python from v2.2.1 to v2.2.2 (#60) - (**deps**) Bump actions/cache from v2.1.4 to v2.1.5 (#61) - (**deps**) Bump pre-commit/action from v2.0.0 to v2.0.3 (#62) - Update Python dev version to 3.9.5 (#65) - 21.2.0 Release (#68) - 21.2.0 Release (#68) (#69)
Merged
playpauseandstop
added a commit
that referenced
this pull request
May 12, 2021
Now `badabump` supports backticks in release notes, which allows to put code
blocks in GitHub Releases description, using standard Markdown syntax,
```python
def new_release() -> str:
return "It is working!"
```
Features:
---------
- [#34] Put refactor commits into separate section (#58)
Fixes:
------
- [#64] Support pre-releases with multiple digits (#66)
- [#63] Escape backticks when setting output at GitHub Actions (#67)
- [#63] Do not escape backticks & shell vars (#70)
Other:
------
- (**deps-dev**) Bump coverage from 5.3.1 to 5.4 (#47)
- (**deps-dev**) Bump pytest from 6.2.1 to 6.2.2 (#50)
- (**deps-dev**) Bump pytest-cov from 2.10.1 to 2.11.1 (#49)
- (**deps-dev**) Bump time-machine from 1.3.0 to 2.0.1 (#48)
- (**deps**) Bump peter-evans/create-pull-request from v3.6.0 to v3.8.0 (#51)
- Bump Python dev version to 3.9.2 (#57)
- (**deps**) Bump actions/cache from v2.1.3 to v2.1.4 (#55)
- (**deps**) Bump pypa/gh-action-pypi-publish from v1.4.1 to v1.4.2 (#54)
- (**deps**) Bump peter-evans/create-pull-request from v3.8.0 to v3.8.2 (#56)
- Update to Python 3.9.4 (#59)
- (**deps**) Bump actions/setup-python from v2.2.1 to v2.2.2 (#60)
- (**deps**) Bump actions/cache from v2.1.4 to v2.1.5 (#61)
- (**deps**) Bump pre-commit/action from v2.0.0 to v2.0.3 (#62)
- Update Python dev version to 3.9.5 (#65)
Co-authored-by: playpauseandstop <playpauseandstop@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply same logic as for escaping
%,\n,\r, but now for escaping backticks itself.It also might be useful to escape
$, to avoid bash variable substitution, so add them to escape list as well.Fixes: #63