Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

fix: toHaveSelector when ElementHandle is passed #118

Merged
merged 4 commits into from
Jul 6, 2021

Conversation

mxschmitt
Copy link
Collaborator

Fixes #117

@mxschmitt mxschmitt requested a review from mskelton July 6, 2021 10:15
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2021

Codecov Report

Merging #118 (4c9d963) into master (dd3da8e) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 4c9d963 differs from pull request most recent head 76f01ab. Consider uploading reports for the commit 76f01ab to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
- Coverage   99.09%   99.09%   -0.01%     
==========================================
  Files          18       18              
  Lines         222      221       -1     
  Branches       20       20              
==========================================
- Hits          220      219       -1     
  Misses          2        2              
Impacted Files Coverage Δ
src/matchers/toHaveSelector/index.ts 100.00% <100.00%> (ø)
src/matchers/toHaveSelectorCount/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd3da8e...76f01ab. Read the comment docs.

src/matchers/utils.ts Outdated Show resolved Hide resolved
src/matchers/toHaveSelectorCount/index.ts Outdated Show resolved Hide resolved
src/matchers/toHaveSelector/index.test.ts Outdated Show resolved Hide resolved
mxschmitt and others added 3 commits July 6, 2021 14:56
Co-authored-by: Mark Skelton <mdskelton99@gmail.com>
Co-authored-by: Mark Skelton <mdskelton99@gmail.com>
@mxschmitt mxschmitt merged commit 4446e8e into master Jul 6, 2021
@mxschmitt mxschmitt deleted the bugfix/toHaveSelector-with-element-handle branch July 6, 2021 12:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.7.0 has broken expecting on ElementHandle
3 participants