Skip to content

Commit

Permalink
drivers/net/bonding/bond_3ad: return when there's no aggregator
Browse files Browse the repository at this point in the history
Otherwise we would dereference a NULL aggregator pointer when calling
__set_agg_ports_ready on the line below.

Found by Linux Verification Center (linuxtesting.org) with the SVACE
static analysis tool.

Fixes: 1da177e ("Linux-2.6.12-rc2")
Signed-off-by: Daniil Tatianin <d-tatianin@yandex-team.ru>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
d-tatianin authored and davem330 committed Jan 3, 2023
1 parent d57609f commit 9c80796
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/net/bonding/bond_3ad.c
Original file line number Diff line number Diff line change
Expand Up @@ -1549,6 +1549,7 @@ static void ad_port_selection_logic(struct port *port, bool *update_slave_arr)
slave_err(bond->dev, port->slave->dev,
"Port %d did not find a suitable aggregator\n",
port->actor_port_number);
return;
}
}
/* if all aggregator's ports are READY_N == TRUE, set ready=TRUE
Expand Down

0 comments on commit 9c80796

Please sign in to comment.