Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update s6-overlay and Ubuntu 18.04 #38

Closed
wants to merge 4 commits into from
Closed

Conversation

enoch85
Copy link

@enoch85 enoch85 commented Jan 2, 2019

As the title says.

@gbooker
Copy link
Contributor

gbooker commented Jan 2, 2019

Is there a reason to desire this other than just updating the the "latest and greatest" version? The 16.04 image is still supported by Canonical.

@enoch85
Copy link
Author

enoch85 commented Jan 2, 2019

"latest and greatest"

No, no special reason. Just what you said.

But at the same time I've seen that users had issues with the older S6 so maybe this would solve those issues (the current S6 is very old!), and I don't see any reason to stay on an old version anyway.

@gbooker
Copy link
Contributor

gbooker commented Jan 2, 2019

Upgrading has a risk of breakage in a scenario where it worked previously. This is one of the reasons I've not changed this to an 18.04 base already (same with upgrading S6). Essentially a "if it ain't broke, don't fix it" line of thinking.

I've seen that users had issues with the older S6

Could you expound on this some more?

@enoch85
Copy link
Author

enoch85 commented Jan 2, 2019

Could you expound on this some more?

Here is one example of using a later version of S6. And here are all open issues regarding S6.

ain't broke, don't fix it" line of thinking.

Yeah, I've heard supervisors at several offices I've worked at think like that. They run some Ubuntu 10.04 servers due to that way of thinking. 🙈

In the same way as I understand it, in my role as Sysadmin I like to work with more recent stuff and it's my job to keep it up to date. This is my effort to accomplish that.

I've looked at the Linuxserver Plex docker and they run 18.04 with similar code base, so the only thing here AFAIK is improvements, mostly in S6 as it got a few security tweaks as well.

TBH I haven't tested the whole Docker build process, but if you tell me how, I'd be happy to. I'm not that familiar with Docker, except running them.

Thanks!

@enoch85
Copy link
Author

enoch85 commented Jan 2, 2019

OK, so I figured out how to build this, and it works as expected.

Here is the output.

6c207341754f plex:latest "/init" 5 minutes ago Up 5 minutes (healthy) plex

I then run it, and connected to it. No issues AFAIK.

IMHO this can safley be merged.

@gbooker
Copy link
Contributor

gbooker commented Jan 2, 2019

Your comparison to those running 10.04 is a straw-man argument. After that I'd have a hard time taking anything else you have to say seriously.

Last April, I figured I would upgrade this image to 18.04 when it had been out around a year. Obviously this would also require checking the list everything installed in the image and removing those no longer necessary as well as ensuring all that is required is still present. Then would come rounds of testing. So it's not a trivial task.

P.S. I found it amusing you say "this can safley be merged" and then commit a fix 5 minutes later.

@enoch85 enoch85 closed this Jan 9, 2019
@gbooker gbooker mentioned this pull request Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants