Skip to content

Commit

Permalink
Merge pull request #212 from plivo/SMS-5098-10DLC-management-experien…
Browse files Browse the repository at this point in the history
…ce-upgrade-for-Profile-and-brands-screen-on-Ryuk

Adding CreatedAt field in get and list brand/profile api
  • Loading branch information
narayana-plivo authored Mar 17, 2023
2 parents 0848aa3 + 5a166a1 commit 02f90df
Show file tree
Hide file tree
Showing 14 changed files with 64 additions and 31 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
# Change Log
## [4.39.0](https://github.com/plivo/plivo-ruby/tree/v4.39.0) (2023-03-17)
**Adding new attribute - 'created_at' in List Profiles, Get Profile, List Brands, Get Brand, List Campaigns and Get Campaign APIs**
- dding new attribute - 'created_at' in List Profiles, Get Profile, List Brands, Get Brand, List Campaigns and Get Campaign APIs

## [4.38.1](https://github.com/plivo/plivo-ruby/tree/v4.38.1) (2023-03-06)
**Bug fix on create message**
- Bulk send message fix
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ The Plivo Ruby SDK makes it simpler to integrate communications into your Ruby a
Add this line to your application's Gemfile:

```ruby
gem 'plivo', '>= 4.38.1'
gem 'plivo', '>= 4.39.0'
```

And then execute:
Expand Down
2 changes: 1 addition & 1 deletion lib/plivo/version.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module Plivo
VERSION = "4.38.1".freeze
VERSION = "4.39.0".freeze
end
3 changes: 2 additions & 1 deletion spec/mocks/brandGetResponse.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
"brand_id": "BPL3KN9",
"brand_type": "STARTER",
"ein_issuing_country": "US",
"registration_status": "COMPLETED"
"registration_status": "COMPLETED",
"created_at": "2023-01-16T06:22:35.195487Z"
}
}
27 changes: 18 additions & 9 deletions spec/mocks/brandListResponse.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@
"brand_id": "BPL3KN9",
"brand_type": "STARTER",
"ein_issuing_country": "US",
"registration_status": "COMPLETED"
"registration_status": "COMPLETED",
"created_at": "2023-01-16T06:22:35.195487Z"
},
{
"address": {
Expand All @@ -39,7 +40,8 @@
"entity_type": "INDIVIDUAL",
"profile_uuid": "55515d72-2852-4016-9ed9-c64bd1c0c055",
"registration_status": "COMPLETED",
"vertical": "ENERGY"
"vertical": "ENERGY",
"created_at": "2023-01-16T06:22:35.195487Z"
},
{
"address": {
Expand All @@ -64,7 +66,8 @@
"entity_type": "INDIVIDUAL",
"profile_uuid": "71a18795-77fa-4623-9735-44bbd08d86c4",
"registration_status": "COMPLETED",
"vertical": "ENTERTAINMENT"
"vertical": "ENTERTAINMENT",
"created_at": "2023-01-16T06:22:35.195487Z"
},
{
"address": {
Expand All @@ -81,7 +84,8 @@
"ein_issuing_country": "IN",
"profile_uuid": "d3d85b2d-a4c2-4f7b-a66f-83002a5fd5e8",
"registration_status": "COMPLETED",
"vertical": "ENTERTAINMENT"
"vertical": "ENTERTAINMENT",
"created_at": "2023-01-16T06:22:35.195487Z"
},
{
"address": {
Expand All @@ -100,7 +104,8 @@
"ein_issuing_country": "US",
"profile_uuid": "709a4b1c-bbde-40e6-be36-164b1dc8f718",
"registration_status": "COMPLETED",
"vertical": "ENTERTAINMENT"
"vertical": "ENTERTAINMENT",
"created_at": "2023-01-16T06:22:35.195487Z"
},
{
"address": {
Expand All @@ -127,7 +132,8 @@
"entity_type": "PRIVATE",
"profile_uuid": "a28b5892-4d8b-4098-9fe7-6f786fb0be1f",
"registration_status": "COMPLETED",
"vertical": "ENTERTAINMENT"
"vertical": "ENTERTAINMENT",
"created_at": "2023-01-16T06:22:35.195487Z"
},
{
"address": {
Expand All @@ -152,7 +158,8 @@
"entity_type": "GOVERNMENT",
"profile_uuid": "ca01734d-a86a-4ed4-aa5a-8723cbb595b3",
"registration_status": "COMPLETED",
"vertical": "ENERGY"
"vertical": "ENERGY",
"created_at": "2023-01-16T06:22:35.195487Z"
},
{
"address": {
Expand All @@ -178,7 +185,8 @@
"profile_uuid": "c1a1c66a-2bc4-4150-a3f3-033ec41efc5d",
"registration_status": "COMPLETED",
"vertical": "ENTERTAINMENT",
"website": "hibye.com"
"website": "hibye.com",
"created_at": "2023-01-16T06:22:35.195487Z"
},
{
"address": {
Expand Down Expand Up @@ -207,7 +215,8 @@
"registration_status": "COMPLETED",
"vertical": "PROFESSIONAL",
"vetting_score": 80,
"vetting_status": "ACTIVE"
"vetting_status": "ACTIVE",
"created_at": "2023-01-16T06:22:35.195487Z"
}
]
}
3 changes: 2 additions & 1 deletion spec/mocks/campaignGetResponse.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
"registration_status": "ACTIVE",
"reseller_id": "",
"sub_usecase": "2FA,MARKETING",
"usecase": "STARTER"
"usecase": "STARTER",
"created_at": "2023-01-16T06:22:35.195487Z"
}
}
30 changes: 20 additions & 10 deletions spec/mocks/campaignListResponse.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
"registration_status": "ACTIVE",
"reseller_id": "RFWG6CB",
"sub_usecase": "CUSTOMER_CARE",
"usecase": "STARTER"
"usecase": "STARTER",
"created_at": "2023-01-16T06:22:35.195487Z"
},
{
"brand_id": "BNOOLMO",
Expand All @@ -43,7 +44,8 @@
"registration_status": "FAILED",
"reseller_id": "",
"sub_usecase": "2FA,MARKETING",
"usecase": "STARTER"
"usecase": "STARTER",
"created_at": "2023-01-16T06:22:35.195487Z"
},
{
"brand_id": "BWDWMAC",
Expand All @@ -65,7 +67,8 @@
"registration_status": "ACTIVE",
"reseller_id": "",
"sub_usecase": "2FA,MARKETING",
"usecase": "STARTER"
"usecase": "STARTER",
"created_at": "2023-01-16T06:22:35.195487Z"
},
{
"brand_id": "BCKWPKX",
Expand All @@ -87,7 +90,8 @@
"registration_status": "PROCESSING",
"reseller_id": "",
"sub_usecase": "2FA,MARKETING",
"usecase": "MIXED"
"usecase": "MIXED",
"created_at": "2023-01-16T06:22:35.195487Z"
},
{
"brand_id": "B2IYFNC",
Expand All @@ -109,7 +113,8 @@
"registration_status": "PROCESSING",
"reseller_id": "",
"sub_usecase": "2FA",
"usecase": "STARTER"
"usecase": "STARTER",
"created_at": "2023-01-16T06:22:35.195487Z"
},
{
"brand_id": "BK98MJL",
Expand All @@ -129,7 +134,8 @@
}
},
"registration_status": "ACTIVE",
"reseller_id": ""
"reseller_id": "",
"created_at": "2023-01-16T06:22:35.195487Z"
},
{
"brand_id": "B3WKVGC",
Expand All @@ -151,7 +157,8 @@
"registration_status": "PROCESSING",
"reseller_id": "RFWG6CB",
"sub_usecase": "CUSTOMER_CARE",
"usecase": "STARTER"
"usecase": "STARTER",
"created_at": "2023-01-16T06:22:35.195487Z"
},
{
"brand_id": "BBYQU0Z",
Expand All @@ -172,7 +179,8 @@
},
"registration_status": "PROCESSING",
"reseller_id": "",
"usecase": "2FA"
"usecase": "2FA",
"created_at": "2023-01-16T06:22:35.195487Z"
},
{
"brand_id": "BBYQU0Z",
Expand All @@ -193,7 +201,8 @@
},
"registration_status": "ACTIVE",
"reseller_id": "",
"usecase": "2FA"
"usecase": "2FA",
"created_at": "2023-01-16T06:22:35.195487Z"
},
{
"brand_id": "BBYQU0Z",
Expand All @@ -214,7 +223,8 @@
},
"registration_status": "ACTIVE",
"reseller_id": "",
"usecase": "2FA"
"usecase": "2FA",
"created_at": "2023-01-16T06:22:35.195487Z"
}
]
}
3 changes: 2 additions & 1 deletion spec/mocks/campaignUpdateResponse.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
"registration_status": "ACTIVE",
"reseller_id": "",
"sub_usecase": "2FA,MARKETING",
"usecase": "STARTER"
"usecase": "STARTER",
"created_at": "2023-01-16T06:22:35.195487Z"
}
}
3 changes: 2 additions & 1 deletion spec/mocks/profileGetResponse.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
"stock_exchange": "NASDAQ",
"stock_symbol": "ABC",
"vertical": "PROFESSIONAL",
"website": "google.com"
"website": "google.com",
"created_at": "2023-01-16T06:22:35.195487Z"
}
}
6 changes: 4 additions & 2 deletions spec/mocks/profileListResponse.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@
"stock_exchange": "NYSE",
"stock_symbol": "TESLA",
"vertical": "ENTERTAINMENT",
"website": "hibye.com"
"website": "hibye.com",
"created_at": "2023-01-16T06:22:35.195487Z"
},
{
"address": {
Expand Down Expand Up @@ -62,7 +63,8 @@
"stock_exchange": "NYSE",
"stock_symbol": "TESLA",
"vertical": "ENTERTAINMENT",
"website": "hibye.com"
"website": "hibye.com",
"created_at": "2023-01-16T06:22:35.195487Z"
}
]
}
3 changes: 2 additions & 1 deletion spec/mocks/profileUpdateResponse.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
"profile_type": "SECONDARY",
"profile_uuid": "09322f43-fe16-4525-b8e4-4229c867795d",
"vertical": "ENERGY",
"website": "www.google.com"
"website": "www.google.com",
"created_at": "2023-01-16T06:22:35.195487Z"
}
}
3 changes: 2 additions & 1 deletion spec/resource_brand_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ def to_json_brand(obj)
entity_type: obj['entity_type'],
ein: obj['ein'],
website: obj['website'],
company_name: obj['company_name']
company_name: obj['company_name'],
created_at: obj['created_at']

}.reject { |_, v| v.nil? }.to_json
end
Expand Down
3 changes: 2 additions & 1 deletion spec/resource_campaign_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ def to_json_campaign(obj)
reseller_id: obj['reseller_id'],
usecase: obj['usecase'],
registration_status: obj['registration_status'],
sub_usecase: obj['sub_usecase']
sub_usecase: obj['sub_usecase'],
created_at: obj['created_at']
}.reject { |_, v| v.nil? }.to_json
end
def to_json_list(list_object)
Expand Down
3 changes: 2 additions & 1 deletion spec/resource_profile_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ def to_json_profile(obj)
alt_business_id_type: obj['alt_business_id_type'],
alt_business_id: obj['alt_business_id'],
address: obj['address'],
authorized_contact: obj['authorized_contact']
authorized_contact: obj['authorized_contact'],
created_at: obj['created_at']
}.reject { |_, v| v.nil? }.to_json
end
def to_json_list(list_object)
Expand Down

0 comments on commit 02f90df

Please sign in to comment.