Skip to content

Commit

Permalink
Merge pull request #171 from plivo/SUP-2780
Browse files Browse the repository at this point in the history
SUP-2780 : Issue with API Response - Start Recording a Call
  • Loading branch information
huzaif-plivo authored Feb 2, 2022
2 parents 78a5e08 + 5f2ff0b commit 33de54f
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 3 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Change Log

## [4.25.1](https://github.com/plivo/plivo-ruby/tree/v4.25.1) (2022-02-02)
**Bugfix - Recording**
- Fix for Start Recording API response issue

## [4.25.0](https://github.com/plivo/plivo-ruby/tree/v4.25.0) (2022-01-27)
**Features - MPCStartCallRecording**
- parameter name change from statusCallback to recordingCallback
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ The Plivo Ruby SDK makes it simpler to integrate communications into your Ruby a
Add this line to your application's Gemfile:

```ruby
gem 'plivo', '>= 4.25.0'
gem 'plivo', '>= 4.25.1'
```

And then execute:
Expand Down
6 changes: 5 additions & 1 deletion lib/plivo/resources/calls.rb
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,11 @@ def delete(call_uuid)
# @option options [String] :callback_method - The method which is used to invoke the callback_url URL. Defaults to POST.
def record(call_uuid, options = nil)
valid_param?(:call_uuid, call_uuid, [String, Symbol], true)
Call.new(@_client, resource_id: call_uuid).record(options)
response = Call.new(@_client, resource_id: call_uuid).record(options)
return Base::Response.new(Hash["api_id" => response.api_id,
"recording_id" => response.recording_id,
"message" => response.message,
"url" => response.url])
end

# @param [String] call_uuid
Expand Down
2 changes: 1 addition & 1 deletion lib/plivo/version.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module Plivo
VERSION = "4.25.0".freeze
VERSION = "4.25.1".freeze
end

0 comments on commit 33de54f

Please sign in to comment.