Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VT-3755 StirShaken phase 2 - SDK implementation #167

Merged
merged 4 commits into from
Jul 11, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Change Log

## [4.28.0](https://github.com/plivo/plivo-go/tree/v4.28.0) (2022-07-11)
**Feature - STIR Attestation**
- Add stir attestation param as part of Get CDR and Get live call APIs Response

## [4.27.1](https://github.com/plivo/plivo-ruby/tree/v4.27.1) (2022-06-30)
- `from_number`, `to_number` and `stir_verification` added to filter param [Retrieve all calls] (https://www.plivo.com/docs/voice/api/call#retrieve-all-calls)

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ The Plivo Ruby SDK makes it simpler to integrate communications into your Ruby a
Add this line to your application's Gemfile:

```ruby
gem 'plivo', '>= 4.27.1'
gem 'plivo', '>= 4.28.0'
```

And then execute:
Expand Down
3 changes: 2 additions & 1 deletion lib/plivo/resources/calls.rb
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,8 @@ def to_s
request_uuid: @request_uuid,
direction: @direction,
caller_name: @caller_name,
stir_verification: @stir_verification
stir_verification: @stir_verification,
stir_attestation: @stir_attestation
}
call_details = call_details.select {|k, v| !v.nil? }
call_details.to_s
Expand Down
2 changes: 1 addition & 1 deletion lib/plivo/version.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module Plivo
VERSION = "4.27.1".freeze
VERSION = "4.28.0".freeze
end
3 changes: 2 additions & 1 deletion spec/mocks/callGetResponse.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,6 @@
"to_number": "919999999999",
"total_amount": "0.00000",
"total_rate": "0.03570",
"stir_verification": "Verified"
"stir_verification": "Verified",
"stir_attestation": "A"
}
6 changes: 4 additions & 2 deletions spec/mocks/callListResponse.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@
"to_number": "14153268174",
"total_amount": "0.13600",
"total_rate": "0.00850",
"stir_verification": "Not Verified"
"stir_verification": "Not Verified",
"stir_attestation": ""
},
{
"answer_time": "2015-07-26 16:45:02+05:30",
Expand All @@ -42,7 +43,8 @@
"to_number": "14153268174",
"total_amount": "0.13600",
"total_rate": "0.00850",
"stir_verification": "Not Applicable"
"stir_verification": "Not Applicable",
"stir_attestation": ""
}
]
}
3 changes: 2 additions & 1 deletion spec/mocks/liveCallGetResponse.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,6 @@
"request_uuid": "d0a87a1a-b0e9-4ab2-ac07-c22ee87cd04a",
"session_start": "2017-05-22 13:17:49.050872",
"to": "919798990001",
"stir_verification": "Not Applicable"
"stir_verification": "Not Applicable",
"stir_attestation": ""
}
6 changes: 4 additions & 2 deletions spec/resource_calls_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ def to_json(call)
to_number: call.to_number,
total_amount: call.total_amount,
total_rate: call.total_rate,
stir_verification: call.stir_verification
stir_verification: call.stir_verification,
stir_attestation:call.stir_attestation
}.to_json
end

Expand All @@ -33,7 +34,8 @@ def to_json_live(call)
call_uuid: call.call_uuid,
request_uuid: call.request_uuid,
session_start: call.session_start,
stir_verification: call.stir_verification
stir_verification: call.stir_verification,
stir_attestation: call.stir_attestation
}.to_json
end

Expand Down