Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add margins around milestone cards #123

Closed
juliaxbow opened this issue Nov 17, 2022 · 2 comments · Fixed by #174
Closed

Add margins around milestone cards #123

juliaxbow opened this issue Nov 17, 2022 · 2 comments · Fixed by #174
Assignees
@whizzzkid
Labels
effort/hours The work in this issue, which should be status/ready, should take less than 1/2 day to complete MVP P1 status/ready This issue has enough information to be worked on and no technical blockers or pre-reqs UI The issue pertains to visual touchpoints

Comments

@juliaxbow
Copy link
Collaborator

Milestone cards stacked horizontally are a little cramped. Should be same margins on left/right as are on top/bottom
Screen Shot 2022-11-16 at 6 49 08 PM
@juliaxbow juliaxbow added UI The issue pertains to visual touchpoints P2 labels Nov 17, 2022
@momack2
Copy link

momack2 commented Nov 17, 2022 •
edited
Loading

CleanShot 2022-11-16 at 19 32 42

Similarly - when showing the theme color background, there should be the same (bigger please) margin of the color on top and bottom (instead of the card taking up the whole height of the row)

@SgtPooki SgtPooki added MVP status/ready This issue has enough information to be worked on and no technical blockers or pre-reqs effort/hours The work in this issue, which should be status/ready, should take less than 1/2 day to complete P1 and removed P2 labels Nov 17, 2022
@SgtPooki SgtPooki added this to Starmap Nov 22, 2022
@SgtPooki SgtPooki moved this to Todo in Starmap Nov 22, 2022
@juliaxbow juliaxbow assigned juliaxbow and unassigned juliaxbow Nov 22, 2022
@whizzzkid whizzzkid self-assigned this Nov 22, 2022
@SgtPooki
Copy link
Contributor

I think the fix here is to remove the group title from the subgrid, position it above it, and then add row-gap to the subgrids

@whizzzkid whizzzkid mentioned this issue Nov 23, 2022
Merged
@whizzzkid whizzzkid moved this from Todo to Peer Review in Starmap Nov 23, 2022
Repository owner moved this from Peer Review to Done in Starmap Nov 23, 2022
SgtPooki added a commit that referenced this issue Feb 11, 2023
@SgtPooki
fix: parsing children: with only #123 identifier
b9e04dc
SgtPooki added a commit that referenced this issue Feb 16, 2023
@SgtPooki @whizzzkid
feat: support children via GitHub Taskslist (#315)
b3d13d9 
* chore: add unit test for getChildren

* chore: support parsing issue body_text

* feat: support reading children from tasklists

* fix: parsing children: with only #123 identifier

* docs: update User Guide with tasklist instructions

* Update lib/parser.ts

Co-authored-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>

* chore: address PR comments

---------

Co-authored-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whizzzkid whizzzkid

Labels
effort/hours The work in this issue, which should be status/ready, should take less than 1/2 day to complete MVP P1 status/ready This issue has enough information to be worked on and no technical blockers or pre-reqs UI The issue pertains to visual touchpoints
Projects
Starmap
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Milestone styling in both simple and detail view pln-planning-tools/Starmap
4 participants
@momack2 @SgtPooki @whizzzkid @juliaxbow