remove hack/workaround for tekton bug that was creating multiple tekton tasks that has been fixed in latest tekton release #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andykrohg you have a tekton test environment up right now on latest tekton version and i don't, mind giving this a shot? |
|
ugggg, i dont know why the tests just failed....don't have time to look at right now |
itewk
force-pushed
the
feature/tekton-remove-hacks
branch
6 times, most recently
from
f6dce65
to
7e97f86
Compare
…on tasks that has been fixed in latest tekton release
* update minimum workflow to allign with new minimum * add tekton typical workflow * update everything workflow to align with new everything * add reporting to finally * move all charts starting with 'ploigos-workflow-' to 'charts/plogigos-workflow/' and remove the prefix to work around helm/chart-testing#343 * update README to reflect local testing updates * update to use 'ref' instead of 'name' for EventListener TriggerTemplate references due to deprivation of 'name' parameter * .github workflows * in testing kind cluster create default IngressClass * upgrade testing to use helm 3.6.1 * CHARTS_DIR env variable
itewk
force-pushed
the
feature/tekton-remove-hacks
branch
from
7e97f86
to
5564dd0
Compare
itewk
force-pushed
the
feature/tekton-remove-hacks
branch
from
7e9247e
to
f322d7d
Compare
|
skipping review. @andykrohg operator i dont think will need any updates due to these changes other then pulling new version of charts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
purpose
there was an epic hack tro try and work around the following teckton bugs
Those are all fixed now so those workaround/hacks are no longer needed.
fix
remove the hacks.
testing
tested the minimal, typical, and everything workflows.