Regression: paste buttons should check for the __cp cookie

[ale-rt]

If I go to the @@folder_contents view, on Plone 5.0.8 the paste button is disable until I copy something:

On Plone 5.1rc2 the button is always enabled:

[ale-rt]

Maybe fixed by plone/mockup@9576b3e

[jensens]

@thet can you confirm this?

[gp54321]

@ale-rt : this fix you were considering in Februar is in Plone (at least in 5.1.2) and the problem is still here.

My guess: this change seems a much more likely culprit.

[gp54321]

After a few testing, reverting this fix is still possible, it fixes this particular problem
I'll add a comment to the patch.

[ale-rt]

Thanks for your findings @gp54321!

[vincentfretin]

@gp54321 @ale-rt
In plone/mockup#996
I reverted part of plone/mockup@b470e35
to fix the disabled state of action buttons in folder contents that are using <a> tag and not <button> or <input>

@gp54321 You said in your comment plone/mockup@b470e35#commitcomment-29331299 there was another regression in thememapper http://0.0.0.0:8080/Plone/++theme++newtheme/@@theming-controlpanel-mapper about the Tools->Build CSS that wasn't disabled when not selecting a less file? Reverting the commit did not bring the feature back. Maybe there was another change in plone.app.theming since then...
Which version of Plone was it when you said the revert of the commit brought back the feature?

[vincentfretin]

Ah from this screenshot plone/plone.app.theming#86 (comment) we had no Tools dropdown before, so I guess you were talking of the button Build CSS in these old version.

[vincentfretin]

The Build CSS button was changed from a ButtonView (which I fixed) to an AnchorView in this commit
plone/mockup@3a414c2#diff-c4515929473f2d17ec9b635ce0d70e14R545
AnchorView has the same issue using prop('disabled') on a <a> tag (the commit was done after plone/mockup@b470e35 so it copied the bug). If I do a similar fix, the button have the disabled class, but it doesn't look like it's disabled, so maybe there is now a css issue with this Tools dropdown.

[vincentfretin]

Yep, I added a css rule to fix it. plone/mockup#996 fixes all issues now.