Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression for disabled state of action buttons in folder contents #996

Merged
merged 5 commits into from
Jul 5, 2020
Merged

Fix regression for disabled state of action buttons in folder contents #996

merged 5 commits into from
Jul 5, 2020

Conversation

vincentfretin
Copy link
Member

@mister-roboto
Copy link

@vincentfretin thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@vincentfretin vincentfretin force-pushed the fix-disabled-a-tag-btn branch from 84967d0 to 8e99b06 Compare July 5, 2020 09:13
@vincentfretin
Copy link
Member Author

@jenkins-plone-org please run jobs

@vincentfretin
Fix regression for disabled state of action buttons in folder content…
1000ce7 
…s that are using <a> tag and not <button> or <input>

(this revert part of b470e35)
@vincentfretin vincentfretin force-pushed the fix-disabled-a-tag-btn branch from 8e99b06 to 1000ce7 Compare July 5, 2020 09:29
@vincentfretin vincentfretin mentioned this pull request Jul 5, 2020
Closed
@vincentfretin
Copy link
Member Author

@jenkins-plone-org please run jobs

@vincentfretin
Copy link
Member Author

vincentfretin commented Jul 5, 2020 •
edited
Loading

If you look at the component, this is using

var ButtonView = BaseView.extend({
    tagName: 'a',

prop("disabled", ...) doesn't do anything on a <a> tag, so I reverted some of the changes of b470e35

@vincentfretin vincentfretin merged commit cc8a307 into master Jul 5, 2020
@vincentfretin vincentfretin deleted the fix-disabled-a-tag-btn branch July 5, 2020 16:00
This was referenced Jul 5, 2020
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression: paste buttons should check for the __cp cookie
2 participants
@vincentfretin @mister-roboto