Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOT FOR MERGE: Test restapi change with coredev update. #737

Closed
wants to merge 2 commits into from

Conversation

jensens
Copy link
Member

@jensens jensens commented Aug 30, 2021

@jensens jensens changed the title NOT FOR MERGE: Test restapi chnage with coredev update. NOT FOR MERGE: Test restapi change with coredev update. Aug 30, 2021
@jensens jensens marked this pull request as ready for review August 30, 2021 19:20
@jensens
Copy link
Member Author

jensens commented Aug 30, 2021

@jenkins-plone-org please run jobs

1 similar comment
@jensens
Copy link
Member Author

jensens commented Aug 31, 2021

@jenkins-plone-org please run jobs

@jensens
Copy link
Member Author

jensens commented Aug 31, 2021

The branch testing seems not to work with Jenkins? I think I saw it working on some of @mauritsvanrees branches.

@wesleybl wesleybl marked this pull request as draft August 31, 2021 12:13
@wesleybl wesleybl changed the base branch from update-pyjwt to 6.0 August 31, 2021 12:14
@wesleybl
Copy link
Member

@jenkins-plone-org please run jobs

@wesleybl
Copy link
Member

wesleybl commented Aug 31, 2021

@jensens It seems that only PRs that point to the 6.0 and 5.2 branches run Jenkins. This PR was pointing to the update-pyjwt branch. I pointed it to branch 6.0 and now Jenkins runs.

@mauritsvanrees It would be nice if all PRs run Jenkins.

@mauritsvanrees
Copy link
Member

Problem is that when you create a PR to merge branch A into branch B, and branch B is not one of the standard branches, then Jenkins has no idea what to do with it. For starters, it has no idea which Python versions to test this with.

@jensens jensens closed this Aug 31, 2021
@jensens jensens deleted the not-for-merge_update-pyjwt-and-test-with-restapi branch August 31, 2021 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants