Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test 6.0 on Python 3.9 instead of 3.8. #377

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Test 6.0 on Python 3.9 instead of 3.8. #377

merged 1 commit into from
Dec 9, 2024

Conversation

mauritsvanrees
Copy link
Member

Python 3.8 is out of security support, so I will officially drop it from Plone 6.0 soon. As we say in the release schedule: "Plone 6.0 works on Python 3.8, but this Python version reaches end of life in October 2024. At that point, Plone 6 will drop support for Python 3.8."

We don't want to explicitly break it, so definitely no requires_python=">=3.9". But I am not going to take care of version pins for 3.8. If someone wants to keep using it on 3.8, it is there responsibility to keep their own version list.

While updating versions for 6.1 I already saw one or two that dropped support for 3.8. I will be updating the 6.0 versions soon too, so then it would be better if Jenkins tests 6.0 on 3.9 instead of 3.8.

This PR has a few other Python updates. I think I have it correctly, but please check. :-)

mauritsvanrees added a commit to plone/buildout.coredev that referenced this pull request Dec 6, 2024
Python 3.8 is out of security support, so I will officially drop it from Plone 6.0 soon.  As we say in the [release schedule](https://plone.org/download/release-schedule): "Plone 6.0 works on Python 3.8, but this Python version reaches end of life in October 2024. At that point, Plone 6 will drop support for Python 3.8."  See also plone/jenkins.plone.org#377

We also need to stop testing on macos-12 as it may fail soon.  See #967
Updated to macos-13 for now.

Updated pip, setuptools, buildout.
For the moment I kept setuptools at the highest version that still supports Python 3.8, but I want to increase that.  It would break Jenkins currently without the other PR I mentioned.

Update Zope to latest 5.11.1.

I will make this a draft PR, as the `Products.validation` tests fail due to an updated `zope.i18nmessageid`.  I am preparing a workaround for that:
plone/Products.validation#14
Copy link
Member

@gforcada gforcada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks, I will deploy them right away

@gforcada gforcada merged commit c8cecfb into master Dec 9, 2024
1 check passed
@gforcada gforcada deleted the maurits-60-39 branch December 9, 2024 21:21
@gforcada
Copy link
Member

gforcada commented Dec 9, 2024

There is some extra tasks to be done after this merge:

  • deploy the changes
  • update mr.roboto mapping
  • update jenkins.plone.org main tab and remove/disable old jobs

Do I miss anything? 🤔

@gforcada
Copy link
Member

gforcada commented Dec 9, 2024

The mr.roboto update:

py_versions = {'5.2': ['2.7', '3.8'], '6.0': ['3.9', '3.11'], '6.1': ['3.10', '3.12']}

@mauritsvanrees are those the right combinations?

@gforcada
Copy link
Member

gforcada commented Dec 9, 2024

@mauritsvanrees I took the liberty to create a Plone 5.2 view, so we can remove them from the Core view. I guess not so many contributors will miss it 😅

@gforcada
Copy link
Member

gforcada commented Dec 9, 2024

Jenkins views updated as well 👍🏾

@mauritsvanrees
Copy link
Member Author

The mr.roboto update:

py_versions = {'5.2': ['2.7', '3.8'], '6.0': ['3.9', '3.11'], '6.1': ['3.10', '3.12']}

@mauritsvanrees are those the right combinations?

Thanks for following up, Gil! Also thanks for moving the 5.2 jobs to a different view. As long as it is reasonably doable to keep those jobs, it is nice, so we can still run tests if needed for the odd change. If it takes too much effort, we can also drop them, as 5.2 is not supported anymore.

These mr.roboto combinations are for which PR jobs get started, right?
I think the minimum versions are good. For 6.0 and 6.1 we can debate which maximum versions to test with. The mr.roboto configuration now matches the Jenkins Core view, so that is good.

What we could change:

  • Test 6.0 on 3.9 and 3.12.
    • Have only those two on the Core view.
    • Configure mr.roboto to create PR jobs for those two Python versions.
    • Make sure 3.10 and 3.11 are on the Core schedules view.
    • I expect that soon we can claim that 6.0 supports Python 3.13 as well. At that point we could add 3.13 to Core, let mr.roboto create PR jobs for that, and move 3.12 to Core schedules. We can also wait with changing anything further until this is the case.
  • Test 6.1 on 3.10 and 3.13.
    • Have only those two on the Core view (currently we have 3.10, 3.12 and 3.13).
    • Configure mr.roboto to create PR jobs for those two Python versions.
    • Make sure 3.11 and 3.12 are on the Core schedules view.

mauritsvanrees added a commit to plone/buildout.coredev that referenced this pull request Dec 10, 2024
Python 3.8 is out of security support, so I will officially drop it from Plone 6.0 soon.  As we say in the [release schedule](https://plone.org/download/release-schedule): "Plone 6.0 works on Python 3.8, but this Python version reaches end of life in October 2024. At that point, Plone 6 will drop support for Python 3.8."  See also plone/jenkins.plone.org#377

We also need to stop testing on macos-12 as it may fail soon.  See #967
Updated to macos-13 for now.

Updated pip, setuptools, buildout.
For the moment I kept setuptools at the highest version that still supports Python 3.8, but I want to increase that.  It would break Jenkins currently without the other PR I mentioned.

Update Zope to latest 5.11.1.

I will make this a draft PR, as the `Products.validation` tests fail due to an updated `zope.i18nmessageid`.  I am preparing a workaround for that:
plone/Products.validation#14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants