-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test 6.0 on Python 3.9 instead of 3.8. #377
Conversation
Python 3.8 is out of security support, so I will officially drop it from Plone 6.0 soon. As we say in the [release schedule](https://plone.org/download/release-schedule): "Plone 6.0 works on Python 3.8, but this Python version reaches end of life in October 2024. At that point, Plone 6 will drop support for Python 3.8." See also plone/jenkins.plone.org#377 We also need to stop testing on macos-12 as it may fail soon. See #967 Updated to macos-13 for now. Updated pip, setuptools, buildout. For the moment I kept setuptools at the highest version that still supports Python 3.8, but I want to increase that. It would break Jenkins currently without the other PR I mentioned. Update Zope to latest 5.11.1. I will make this a draft PR, as the `Products.validation` tests fail due to an updated `zope.i18nmessageid`. I am preparing a workaround for that: plone/Products.validation#14
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks, I will deploy them right away
There is some extra tasks to be done after this merge:
Do I miss anything? 🤔 |
The mr.roboto update: py_versions = {'5.2': ['2.7', '3.8'], '6.0': ['3.9', '3.11'], '6.1': ['3.10', '3.12']} @mauritsvanrees are those the right combinations? |
@mauritsvanrees I took the liberty to create a |
Jenkins views updated as well 👍🏾 |
Thanks for following up, Gil! Also thanks for moving the 5.2 jobs to a different view. As long as it is reasonably doable to keep those jobs, it is nice, so we can still run tests if needed for the odd change. If it takes too much effort, we can also drop them, as 5.2 is not supported anymore. These mr.roboto combinations are for which PR jobs get started, right? What we could change:
|
Python 3.8 is out of security support, so I will officially drop it from Plone 6.0 soon. As we say in the [release schedule](https://plone.org/download/release-schedule): "Plone 6.0 works on Python 3.8, but this Python version reaches end of life in October 2024. At that point, Plone 6 will drop support for Python 3.8." See also plone/jenkins.plone.org#377 We also need to stop testing on macos-12 as it may fail soon. See #967 Updated to macos-13 for now. Updated pip, setuptools, buildout. For the moment I kept setuptools at the highest version that still supports Python 3.8, but I want to increase that. It would break Jenkins currently without the other PR I mentioned. Update Zope to latest 5.11.1. I will make this a draft PR, as the `Products.validation` tests fail due to an updated `zope.i18nmessageid`. I am preparing a workaround for that: plone/Products.validation#14
Python 3.8 is out of security support, so I will officially drop it from Plone 6.0 soon. As we say in the release schedule: "Plone 6.0 works on Python 3.8, but this Python version reaches end of life in October 2024. At that point, Plone 6 will drop support for Python 3.8."
We don't want to explicitly break it, so definitely no
requires_python=">=3.9"
. But I am not going to take care of version pins for 3.8. If someone wants to keep using it on 3.8, it is there responsibility to keep their own version list.While updating versions for 6.1 I already saw one or two that dropped support for 3.8. I will be updating the 6.0 versions soon too, so then it would be better if Jenkins tests 6.0 on 3.9 instead of 3.8.
This PR has a few other Python updates. I think I have it correctly, but please check. :-)