Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make view-icon in tablerow.xml translatable #537

Closed
pbauer opened this issue Jul 23, 2015 · 4 comments
Closed

Make view-icon in tablerow.xml translatable #537

pbauer opened this issue Jul 23, 2015 · 4 comments

Comments

@pbauer
Copy link
Member

pbauer commented Jul 23, 2015

title="View" in mockup/mockup/patterns/structure/templates/tablerow.xml is not translatable.
I tried it by replacing it with title="<%- _t('View') %>" and amending tablerow.js to support _t but failed 😢

@vangheem
Copy link
Member

Does this work: #539 ?

I didn't test myself so if you can, that'd be great!

@pbauer
Copy link
Member Author

pbauer commented Jul 23, 2015

That works \o/
There is a insane number of layers of caching to work around when trying it out:

Forget one of these and you'll not see the current state fo the code.

@vangheem
Copy link
Member

What might help is to always disable caching when you have developer tools open.

@vangheem
Copy link
Member

but yah, you have to clear localstorage too :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants