Translations in folder_contents are incomplete

[tomgross]

Partly this looks like a regression to 5.1b4. The translation coverage was better there.

What I did:

• Install Plone 5.1rc1 and set a language different to English.
• Go to folder_contents of the site or a folder.

What I expect to happen:

• All actions are translated to the selected language.

What actually happened:

• NOT all actions are translated to the selected language.

What version of Plone/ Addons I am using:

• Plone 5.1rc1

[mauritsvanrees]

When I search for 'Move to top of folder' I only find this in mockup/patterns/structure/js/actionmenu.js. So it has something to do with Javascript translations.
@thet Does this ring a bell for you?

[terapyon]

I want to fix it.

[vincentfretin]

The issue with those actions Copy, Move to top of folder, Move to bottom of folder, Set as default page still exists.

Here is a complete list I think:

• Copy, Move to top of folder, Move to bottom of folder, Set as default page fix some i18n issues mockup#992
• review states are not translated Review state should be translatable on folder_contents page #2419
• tooltip on the content type icons not translated Tooltip on content-type icon in folder contents view is not translated mockup#993
• tooltip on action "Open" not translated fix some i18n issues mockup#992
• in the filter dialog, "No sorting" not translated fix some i18n issues mockup#992
• in selected items dialog, "Filter" not translated In selected items dialog, "Filter" not translated mockup#997
• in properties dialog: "Modify properties on items" and "No change" not translated folder_contents 5.1RC2 untranslated properties dialog #2313
• in properties dialog: the pickadate doesn't use the correct locale config "Properties" dialog of folder contents, locale issues #850
• in keywords dialog, "No matches found", "Searching..." no translated Select2 based widgets show always english messages mockup#994
• in State dialog "Change workflow of selected items" is not translated In folder contents view the title of the Workflow change modal is not translated mockup#995
• Issue with the date format, it shows for example PM for language that doesn't use this like French pickadate widget doesn't use the correct 24h format in some languages #3134
• Issue with the "last modified" line "last modified" dates format: not the same in "View" and in "Contents" of a folder #2953

[vincentfretin]

Does anyone has the knowledge how to debug this? Like how do we modify the files of mockup and see the changes in a buildout.coredev 5.2?
Maybe someone who did the latest mockup / plone.staticresources bundle recently can tell us? @thet maybe?

[vincentfretin]

I only know how to create widgets.pot from the https://github.com/plone/mockup/ repository with yarn && make i18n-dump and copy widgets.pot generated in the working directory to plone.app.locales/plone/app/locales/locales/widgets.pot and then run bin/i18n widgets from buildout.coredev 5.2.
What I don't know is how to modify the mockup javascripts files and see the changes in Plone.

[vincentfretin]

@thet @davisagli @adam139 @parruc @frapell Do you know how to modify mockup files and see the changes in Plone? I see what I need to change to fix #3120 but I don't know how to test it.

[frapell]

@vincentfretin You need to go to the site setup, and then to the "Resource registries". In there you should see a checkbox that will enable "Dev mode" for resources. Next, you can enable dev mode for JS or CSS resources (I believe in your case you will only want to enable JS) I think the bundle you are looking for is "plone-logged-in" but it could be some other, I don't remember at this time.

[vincentfretin]

Thanks you @frapell ! Now we're talking.
So from buildout.coredev, if you change something in src/mockup/mockup/patterns/structure/js/actionmenu.js
and want to see the change:
Go to Site Setup->Resource Registries, click on "Development Mode(only logged in users)" checkbox, then on "Develop Javascript" button for the plone-editor-tools bundle and then click the "Save" button.

[vincentfretin]

OMG how does this stuff works? I started to write documentation of what I know there plone/mockup#985
How do you make changes to the translations and see the changes? Does the translation needs to be converted in json or something? How does it work?

[vincentfretin]

I found out. The translations are handled by mockup/js/i18n.js that calls the plonejsi18n view in plone.app.content apparently to generate a live json from the mo file. The view is called one time for a given domain and language and the result is cached in localStorage for 24 hours. The only way to test the new translations is to restart the instance to update the mo file from the po file, and then to purge the localStorage to trigger a new download of the translations.

[frapell]

@vincentfretin I don't know much about the translations, and I didn't know they were cached for 24 hours in localstorage, isn't there a way to avoid that in development? I can imagine being a total pain when adding new translations

[frapell]

@vincentfretin Maybe @thet knows?

[vincentfretin]

@frapell There is no way no, look at the code
https://github.com/plone/mockup/blob/0f4e1d014f305723bdbc7bd8826218ac69168d62/mockup/js/i18n.js#L75-L79
There is no develop flag or anything.

[vincentfretin]

I'm not going to work on it myself. So anybody feel free to continue from here.
I documented how to live debug this in plone/mockup#985
I'm sure some of the issues I listed in #2188 (comment)
can be fixed similarly to other fixes that have already been done like #3120 @djowett-ftw if you want to try.

plone/mockup#539 can help too

[vincentfretin]

@pbauer is one of a few that did know the caching issue in localStorage in 2015 :-)
plone/mockup#537 (comment)

[vincentfretin]

There is actually a dedicated issue for the review state column: #2419

[vincentfretin]

@erral started a branch in mockup plone/mockup#992 to fix some of the issues of the list #2188 (comment)
Thanks you!
If anyone else wants to contribute, please do! :-)

[erral]

I will create specific issues for some of the items described above, because some of them are hard to track down.

[jensens]

I close the issue, because it addresses a Plone version that is no longer supported.
If you think this is wrong please reopen the issue and assign a matching milestone.