Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #345

Merged
merged 4 commits into from
Apr 6, 2022
Merged

Cleanup #345

merged 4 commits into from
Apr 6, 2022

Conversation

jensens
Copy link
Member

@jensens jensens commented Apr 6, 2022

Aftermath of plone/Products.CMFPlone#3395 and cleanup (black, isort, rm six)

@mister-roboto
Copy link

@jensens thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@jensens jensens marked this pull request as ready for review April 6, 2022 15:06
@jensens
Copy link
Member Author

jensens commented Apr 6, 2022

@jenkins-plone-org please run jobs

@jensens jensens merged commit f9cdd4c into master Apr 6, 2022
@jensens jensens deleted the cleanup branch April 6, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants