Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plone.base overhaul #356

Merged
merged 7 commits into from
May 15, 2022
Merged

Plone.base overhaul #356

merged 7 commits into from
May 15, 2022

Conversation

jensens
Copy link
Member

@jensens jensens commented May 4, 2022

isort, black, pyupgrade, no six, use plone.base, manual overhaul.

@jensens jensens requested a review from mauritsvanrees May 4, 2022 20:51
@mister-roboto
Copy link

@jensens thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@jensens
Copy link
Member Author

jensens commented May 4, 2022

@jenkins-plone-org please run jobs

@mauritsvanrees mauritsvanrees merged commit 4b634da into master May 15, 2022
@mauritsvanrees mauritsvanrees deleted the plone.base-overhaul branch May 15, 2022 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants