Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed tests when using Zope 5.11. [1.x, second try] #74

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

mauritsvanrees
Copy link
Member

This is a back port (cherry-picked ) of PR #71 to Plone 6.0.

In one test we got a mappingproxy instead of a dictionary:

File "...plone.base-2.0.1-py3.10.egg/plone/base/tests/messages.rst", line 39, in messages.rst
Failed example:
    msg.mapping
Expected:
    {'name': 'Plone'}
Got:
    mappingproxy({'name': 'Plone'})

In one test we got a `mappingproxy` instead of a dictionary:

```
File "...plone.base-2.0.1-py3.10.egg/plone/base/tests/messages.rst", line 39, in messages.rst
Failed example:
    msg.mapping
Expected:
    {'name': 'Plone'}
Got:
    mappingproxy({'name': 'Plone'})
```
@mister-roboto
Copy link

@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@mauritsvanrees
Copy link
Member Author

Huh, I created a new PR because I accidentally targeted the previous PR #73 at the main branch, and wanted to avoid that the Jenkins 6.1 failures would needlessly be remembered in the checks. But they appear here anyway. Apparently GitHub links them to the branch or to the latest commit. Oh well, just ignore those two failures pleas.

Let's see the results on Jenkins on 6.0 now please:

@jenkins-plone-org please run jobs

@mauritsvanrees
Copy link
Member Author

Both 6.0 Jenkins jobs have the same error for test_dx_event_with_recurrence_new_version in plone.restapi. I suspect that this test might fail depending on at which time or which day it is run. So try again:

@jenkins-plone-org please run jobs

@mauritsvanrees mauritsvanrees merged commit 52285cf into 1.x Dec 10, 2024
12 of 14 checks passed
@mauritsvanrees mauritsvanrees deleted the maurits-mappingproxy-1x branch December 10, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants