Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change login name after changing email in sites where "use email as login" is enabled #1836

Merged
merged 5 commits into from
Nov 8, 2024

Conversation

erral
Copy link
Member

@erral erral commented Nov 4, 2024

Fixes #1835


📚 Documentation preview 📚: https://plonerestapi--1836.org.readthedocs.build/

@mister-roboto
Copy link

@erral thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@erral
Copy link
Member Author

erral commented Nov 4, 2024

@jenkins-plone-org please run jobs

@jensens
Copy link
Member

jensens commented Nov 7, 2024

@jenkins-plone-org please run jobs

@jensens jensens enabled auto-merge (squash) November 7, 2024 10:49
@jensens jensens merged commit 4f3bb4f into main Nov 8, 2024
25 checks passed
@jensens jensens deleted the erral-issue-1835 branch November 8, 2024 21:19
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erral @jensens Thanks.

It looks like PAS can raise a ValueError if there was a problem changing the login, such as no plugin for that or a duplicate with an existing login. We should make sure this returns an error message to the client in a useful way.

@erral erral mentioned this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Email change does not change login name
4 participants