Issue 488 - Rename async modules #489
Conversation
Marc-Andre-Rivet
requested review from
alexcjohnson and
shammamah-zz
as code owners
| pip install -e . | ||
| python setup.py sdist | ||
| cd dist | ||
| find . -name "*.gz" | xargs pip install --no-cache-dir --ignore-installed && cd .. |
There was a problem hiding this comment.
Using the opportunity to install from tarball instead of the local folder -e .. This change helps identify issues when resource paths change and the MANIFEST.in file isn't synced.
| pip install -r tests/requirements.txt --quiet | ||
| pip install dash[testing] | ||
| pip install --progress-bar off -r tests/requirements.txt --quiet | ||
| pip install --progress-bar off dash[testing] |
There was a problem hiding this comment.
No point having thousands of lines of progress bar on each CI run..
| @@ -103,11 +100,11 @@ jobs: | |||
| name: Run integration tests | |||
| command: | | |||
| . venv/bin/activate | |||
| pip install --upgrade pip | |||
| pip install -r tests/requirements.txt | |||
There was a problem hiding this comment.
This step is run after the step above that already installs everything, 🔪
| cython>=0.19 | ||
| dash>=1.6.1 | ||
| dash-bio-utils==0.0.4 | ||
| dash-daq==0.2.2 | ||
| gunicorn==19.9.0 | ||
| jsonschema==2.6.0 | ||
| matplotlib==3.0.2 | ||
| numpy==1.15.4 |
There was a problem hiding this comment.
I feel like I've asked this question before, but does this root requirements.txt file get used anywhere?
There was a problem hiding this comment.
This was originally used for the demo apps but I don't think it needs to be here any more after #459 since the apps each have their own requirements.txt. We should probably replace it with a dev-requirements.txt file instead.
There was a problem hiding this comment.
@shammamah Good to know, thanks! No need to fix now but please make an issue for followup.
Closes #488