Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix background callbacks missing cancel error. #2625

Merged
merged 5 commits into from
Aug 16, 2023
Merged

Fix background callbacks missing cancel error. #2625

merged 5 commits into from
Aug 16, 2023

Conversation

T4rk1n
Copy link
Contributor

@T4rk1n T4rk1n commented Aug 16, 2023

Fix #2624

alexcjohnson
alexcjohnson approved these changes Aug 16, 2023
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 🚀

@T4rk1n T4rk1n merged commit 7dd07d5 into dev Aug 16, 2023
1 check passed
@T4rk1n T4rk1n deleted the fix/#2624 branch August 16, 2023 15:59
@etpinard etpinard mentioned this pull request Apr 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Server fails to setup when using background callbacks without cancel argument
2 participants
@T4rk1n @alexcjohnson