Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

settings: add variable PLOTLY_CONNECTOR_BASE_URL #514

Merged
merged 1 commit into from
Aug 13, 2018
Merged

settings: add variable PLOTLY_CONNECTOR_BASE_URL #514

merged 1 commit into from
Aug 13, 2018

Conversation

n-riesco
Copy link
Contributor

  • Added env variable PLOTLY_CONNECTOR_BASE_URL so that it is possible to
    customise connectorURL when running inside on-prem.

Closes https://github.com/plotly/streambed/issues/11310

@nicolaskruchten @scjody

I've tested the PR locally:

  • running as a desktop app: yarn start
  • and simulating running inside on-prem by setting: PLOTLY_CONNECTOR_BASE_URL="https://test/external-data-connector" PLOTLY_CONNECTOR_RUNNING_INSIDE_ON_PREM=true yarn start

@n-riesco
settings: add variable PLOTLY_CONNECTOR_BASE_URL
98eb276 
* Added env variable PLOTLY_CONNECTOR_BASE_URL so that it is possible to
  customise connectorURL when running inside on-prem.

Closes https://github.com/plotly/streambed/issues/11310
scjody
scjody approved these changes Aug 13, 2018
View reviewed changes
Copy link
Contributor

@scjody scjody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 from me (assuming this is ready for review...)

@nicolaskruchten
Copy link
Contributor

nicolaskruchten commented Aug 13, 2018 via email

@n-riesco n-riesco merged commit 85590b4 into master Aug 13, 2018
@n-riesco n-riesco deleted the onprem/fix-connector-url branch August 29, 2018 15:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@scjody scjody scjody approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@n-riesco @nicolaskruchten @scjody