-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Chart2Music keyboard and sound accessibility features #6680
base: master
Are you sure you want to change the base?
Commits on Jul 21, 2023
-
initial commit, single scatter plot
Alistair-Welch committedJul 21, 2023 Configuration menu - View commit details
-
Copy full SHA for 6fb9c65 - Browse repository at this point
Copy the full SHA 6fb9c65View commit details -
Alistair-Welch committed
Jul 21, 2023 Configuration menu - View commit details
-
Copy full SHA for 87b4c5c - Browse repository at this point
Copy the full SHA 87b4c5cView commit details -
Alistair-Welch committed
Jul 21, 2023 Configuration menu - View commit details
-
Copy full SHA for 64ae505 - Browse repository at this point
Copy the full SHA 64ae505View commit details -
Alistair-Welch committed
Jul 21, 2023 Configuration menu - View commit details
-
Copy full SHA for d37d24f - Browse repository at this point
Copy the full SHA d37d24fView commit details -
Alistair-Welch committed
Jul 21, 2023 Configuration menu - View commit details
-
Copy full SHA for d0467bb - Browse repository at this point
Copy the full SHA d0467bbView commit details -
Alistair-Welch committed
Jul 21, 2023 Configuration menu - View commit details
-
Copy full SHA for 3a73776 - Browse repository at this point
Copy the full SHA 3a73776View commit details -
Alistair-Welch committed
Jul 21, 2023 Configuration menu - View commit details
-
Copy full SHA for b4df959 - Browse repository at this point
Copy the full SHA b4df959View commit details
Commits on Jul 22, 2023
-
Alistair-Welch committed
Jul 22, 2023 Configuration menu - View commit details
-
Copy full SHA for 97b608f - Browse repository at this point
Copy the full SHA 97b608fView commit details -
Alistair-Welch committed
Jul 22, 2023 Configuration menu - View commit details
-
Copy full SHA for 6205d62 - Browse repository at this point
Copy the full SHA 6205d62View commit details -
Alistair-Welch committed
Jul 22, 2023 Configuration menu - View commit details
-
Copy full SHA for 7e40cde - Browse repository at this point
Copy the full SHA 7e40cdeView commit details -
Alistair-Welch committed
Jul 22, 2023 Configuration menu - View commit details
-
Copy full SHA for 6d9185b - Browse repository at this point
Copy the full SHA 6d9185bView commit details -
Alistair-Welch committed
Jul 22, 2023 Configuration menu - View commit details
-
Copy full SHA for 935cf54 - Browse repository at this point
Copy the full SHA 935cf54View commit details -
Alistair-Welch committed
Jul 22, 2023 Configuration menu - View commit details
-
Copy full SHA for 44deae2 - Browse repository at this point
Copy the full SHA 44deae2View commit details
Commits on Jul 28, 2023
-
Alistair-Welch committed
Jul 28, 2023 Configuration menu - View commit details
-
Copy full SHA for c38ab67 - Browse repository at this point
Copy the full SHA c38ab67View commit details -
Alistair-Welch committed
Jul 28, 2023 Configuration menu - View commit details
-
Copy full SHA for c6a27be - Browse repository at this point
Copy the full SHA c6a27beView commit details
Commits on Jul 30, 2023
-
Alistair-Welch committed
Jul 30, 2023 Configuration menu - View commit details
-
Copy full SHA for cac174c - Browse repository at this point
Copy the full SHA cac174cView commit details -
Alistair-Welch committed
Jul 30, 2023 Configuration menu - View commit details
-
Copy full SHA for 159ca1b - Browse repository at this point
Copy the full SHA 159ca1bView commit details
Commits on Jan 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7467a47 - Browse repository at this point
Copy the full SHA 7467a47View commit details -
Remove special rules from webpack.config:
I agree with the contributor's choice of dialetc over plotly's default. However, I think adding piece-meal rules to change how stuff is built will ultimately make it more complicated to refactor, maintain, and read in the future. The current dialect of javascript (enforced primarily by the linter at least in the pull-request stage), is limiting and inconvenient. Migrating to a more modern javascript, I believe, requires a broader strategy.
Configuration menu - View commit details
-
Copy full SHA for 08b820b - Browse repository at this point
Copy the full SHA 08b820bView commit details
Commits on Jan 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 41b0fb9 - Browse repository at this point
Copy the full SHA 41b0fb9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 94e25c3 - Browse repository at this point
Copy the full SHA 94e25c3View commit details
Commits on Jan 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 61ea8ce - Browse repository at this point
Copy the full SHA 61ea8ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for c9a0b91 - Browse repository at this point
Copy the full SHA c9a0b91View commit details -
Configuration menu - View commit details
-
Copy full SHA for cc92639 - Browse repository at this point
Copy the full SHA cc92639View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7baa0d3 - Browse repository at this point
Copy the full SHA 7baa0d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3127dee - Browse repository at this point
Copy the full SHA 3127deeView commit details -
Merge pull request #1 from geopozo/pikul-music-import-promise
Update to your pull-request for making es5/require work.
Configuration menu - View commit details
-
Copy full SHA for 2429e55 - Browse repository at this point
Copy the full SHA 2429e55View commit details -
Configuration menu - View commit details
-
Copy full SHA for 00572e8 - Browse repository at this point
Copy the full SHA 00572e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 30f4e11 - Browse repository at this point
Copy the full SHA 30f4e11View commit details
Commits on Jan 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 247b301 - Browse repository at this point
Copy the full SHA 247b301View commit details -
Add config so dev can place closed captions:
Adding a closed caption div to plotly interefered with plotly's management of it. We now start by default outside of the generated plotly divs. But we add options to users can a) generate it with any id/class. Or specify that it already exists and use an existing element by id.
Configuration menu - View commit details
-
Copy full SHA for d08adfb - Browse repository at this point
Copy the full SHA d08adfbView commit details -
Merge branch 'chart2music' of https://github.com/aliwelchoo/plotly.js …
…into pikul-music-import-promise
Configuration menu - View commit details
-
Copy full SHA for dbce5da - Browse repository at this point
Copy the full SHA dbce5daView commit details -
Configuration menu - View commit details
-
Copy full SHA for e1f9563 - Browse repository at this point
Copy the full SHA e1f9563View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f4ab54 - Browse repository at this point
Copy the full SHA 3f4ab54View commit details -
Skip empty trace data in accessibility.enable:
Passing named empty arrays to chart2music makes it angry during validation.
Configuration menu - View commit details
-
Copy full SHA for 92d97b7 - Browse repository at this point
Copy the full SHA 92d97b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b2dcc9 - Browse repository at this point
Copy the full SHA 6b2dcc9View commit details
Commits on Jan 26, 2024
-
Modify how accessibility treats config vars:
accessibility.js takes configuration variables from `plot_config.js`, modifies them, and passes them directly to `chart2music`. The problem is that assigning an object to a new variable doesn't copy it, so any change to that variable also changes the original object. Plotly uses changes (or lack thereof) in the config variables to decide if it can shortcut certain redraw steps. It cannot if config variables change. So if `accessibility.js` is run on every redraw, the config variables will look different (even if they are not), and plotly will always take the long way around during its rerendering. That being said, this solution here may need more thought. Questions like: when _should_ chart2music ask plotly to do a full redraw? Should it ever? Would it do that by changing a config it has access to? Will it ever change plotly config variables frequently.
Configuration menu - View commit details
-
Copy full SHA for b5bb517 - Browse repository at this point
Copy the full SHA b5bb517View commit details -
Configuration menu - View commit details
-
Copy full SHA for 25ca44a - Browse repository at this point
Copy the full SHA 25ca44aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7328324 - Browse repository at this point
Copy the full SHA 7328324View commit details -
Configuration menu - View commit details
-
Copy full SHA for 00b2750 - Browse repository at this point
Copy the full SHA 00b2750View commit details -
Set c2music default to not make its caption div:
I can't think of instance where 1) the caption div wouldn't be specified by the user 2) would maybe do some really fancy interaction w/ the graph 3) be completely invisible because its meant to be read outloud anyway Either way, the generation strategy needs work. * Tests now create their closed caption div
Configuration menu - View commit details
-
Copy full SHA for b04bb17 - Browse repository at this point
Copy the full SHA b04bb17View commit details -
Configuration menu - View commit details
-
Copy full SHA for d4bd71b - Browse repository at this point
Copy the full SHA d4bd71bView commit details -
Configuration menu - View commit details
-
Copy full SHA for af2ff80 - Browse repository at this point
Copy the full SHA af2ff80View commit details
Commits on Jan 28, 2024
-
Merge pull request #2 from geopozo/pikul-music-import-promise
FIX and Add options to chart2music plotly integration
Configuration menu - View commit details
-
Copy full SHA for 80b4cf3 - Browse repository at this point
Copy the full SHA 80b4cf3View commit details
Commits on Jan 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ee99f35 - Browse repository at this point
Copy the full SHA ee99f35View commit details
Commits on Feb 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3841640 - Browse repository at this point
Copy the full SHA 3841640View commit details
Commits on Feb 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d84d108 - Browse repository at this point
Copy the full SHA d84d108View commit details -
1) Since accessibility.js will support multiple accessibility libraries, there is now a C2M library that contains the API for initializing C2M to plotly charts. 2) The initialization process is split into it's various phases. 3) Trace types now have specific codecs to map plotly-C2M. See the README in each file. 4) xy-scatter codec was refactored a bit to not assume the x-y is domain-range. 5) All config variables are now copied from defaults so C2M doesn't mess with plotly's config obect.
Configuration menu - View commit details
-
Copy full SHA for 0c43407 - Browse repository at this point
Copy the full SHA 0c43407View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c75035 - Browse repository at this point
Copy the full SHA 4c75035View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c49ed6 - Browse repository at this point
Copy the full SHA 3c49ed6View commit details -
Configuration menu - View commit details
-
Copy full SHA for f7be666 - Browse repository at this point
Copy the full SHA f7be666View commit details
Commits on Mar 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4a260af - Browse repository at this point
Copy the full SHA 4a260afView commit details
Commits on Mar 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f67c513 - Browse repository at this point
Copy the full SHA f67c513View commit details
Commits on Mar 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 41baab9 - Browse repository at this point
Copy the full SHA 41baab9View commit details
Commits on Sep 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 26754b7 - Browse repository at this point
Copy the full SHA 26754b7View commit details
Commits on Sep 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ed18907 - Browse repository at this point
Copy the full SHA ed18907View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e4bcef - Browse repository at this point
Copy the full SHA 1e4bcefView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c1abf4 - Browse repository at this point
Copy the full SHA 2c1abf4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 614fb8b - Browse repository at this point
Copy the full SHA 614fb8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f5e599 - Browse repository at this point
Copy the full SHA 5f5e599View commit details -
Configuration menu - View commit details
-
Copy full SHA for fe9736e - Browse repository at this point
Copy the full SHA fe9736eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 59ad5c6 - Browse repository at this point
Copy the full SHA 59ad5c6View commit details
Commits on Sep 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d18c584 - Browse repository at this point
Copy the full SHA d18c584View commit details -
Configuration menu - View commit details
-
Copy full SHA for 043d408 - Browse repository at this point
Copy the full SHA 043d408View commit details -
Configuration menu - View commit details
-
Copy full SHA for 129eb3b - Browse repository at this point
Copy the full SHA 129eb3bView commit details -
Configuration menu - View commit details
-
Copy full SHA for acc8517 - Browse repository at this point
Copy the full SHA acc8517View commit details -
Configuration menu - View commit details
-
Copy full SHA for c5ad240 - Browse repository at this point
Copy the full SHA c5ad240View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0113d90 - Browse repository at this point
Copy the full SHA 0113d90View commit details -
Configuration menu - View commit details
-
Copy full SHA for 771029e - Browse repository at this point
Copy the full SHA 771029eView commit details
Commits on Sep 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bfbbbf1 - Browse repository at this point
Copy the full SHA bfbbbf1View commit details -
Revert "Code readability improvements"
This reverts commit 129eb3b.
Configuration menu - View commit details
-
Copy full SHA for cadfd7f - Browse repository at this point
Copy the full SHA cadfd7fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 56e582d - Browse repository at this point
Copy the full SHA 56e582dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e55f98 - Browse repository at this point
Copy the full SHA 8e55f98View commit details -
Configuration menu - View commit details
-
Copy full SHA for 86d75d8 - Browse repository at this point
Copy the full SHA 86d75d8View commit details
Commits on Oct 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 15671b0 - Browse repository at this point
Copy the full SHA 15671b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 057e067 - Browse repository at this point
Copy the full SHA 057e067View commit details -
Configuration menu - View commit details
-
Copy full SHA for 44f7ad3 - Browse repository at this point
Copy the full SHA 44f7ad3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e3b62b - Browse repository at this point
Copy the full SHA 8e3b62bView commit details -
Configuration menu - View commit details
-
Copy full SHA for aed1e02 - Browse repository at this point
Copy the full SHA aed1e02View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1777fba - Browse repository at this point
Copy the full SHA 1777fbaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a0384f - Browse repository at this point
Copy the full SHA 3a0384fView commit details
Commits on Oct 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for dba0b53 - Browse repository at this point
Copy the full SHA dba0b53View commit details