-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation updates for 5.11 #3931
Conversation
Hey @LiamConnors, I've just merged your changes from |
Thanks @nicolaskruchten. I've done that now. |
## Basic Dumbbell Plot | ||
|
||
|
||
Dumbbell plots are useful for demonstrating change between two sets of data points, for example, the population change for a selection of countries for two different years |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a cool page, thanks for adding it!
Some feedback:
- Neither plot has a legend, because you're using a single trace with hardcoded colors, so there's no way of knowing what green and blue mean. I would suggest a separate trace per year and then another one for the line but hide the line from the legend.
- Along similar lines, it might be cool to have a third example (or a modified second example) with some lines that go the other way and that are colored red, say. Again I would make this a different trace so it can have a legend entry.
This is not blocking feedback, just something that's on my mind as I've always wanted a PX function to do this stuff :)
Documentation PR
doc/README.md
filedoc-prod
branch OR it targets themaster
branchpx
example if at all possibleplotly.graph_objects as go
/plotly.express as px
/plotly.io as pio
df
fig = <something>
call is high up in each new/modified example (eitherpx.<something>
ormake_subplots
orgo.Figure
)fig.add_*
andfig.update_*
rather thango.Figure(data=..., layout=...)
in every new/modified examplefig.add_shape
andfig.update_xaxes
are used instead of bigfig.update_layout
calls in every new/modified examplefig.show()
is at the end of each new/modified exampleplotly.plot()
andplotly.iplot()
are not used in any new/modified exampleCode PR
plotly.graph_objects
, my modifications concern thecodegen
files and not generated files.modified existing tests.
new tutorial notebook (please see the doc checklist as well).
-->