Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codegen with packaging.Version changes #4055

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Conversation

LiamConnors
Copy link
Member

@LiamConnors LiamConnors commented Feb 3, 2023

Updates codegen with changes from #3897

Code PR

  • I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the codegen files and not generated files.
  • I have added tests (if submitting a new feature or correcting a bug) or
    modified existing tests.
  • For a new feature, I have added documentation examples in an existing or
    new tutorial notebook (please see the doc checklist as well).
  • I have added a CHANGELOG entry if fixing/changing/adding anything substantial.
  • For a new feature or a change in behaviour, I have updated the relevant docstrings in the code to describe the feature or behaviour (please see the doc checklist as well).

@LiamConnors LiamConnors changed the title Update __init__.py Update codgen with packaging.Version changes Feb 3, 2023
@LiamConnors LiamConnors marked this pull request as ready for review February 3, 2023 20:55
@LiamConnors LiamConnors changed the title Update codgen with packaging.Version changes Update codegen with packaging.Version changes Feb 3, 2023
@nicolaskruchten
Copy link
Contributor

OK this looks good! Did you also run python setup.py updateplotlyjs and there were no additional files changed?

@LiamConnors
Copy link
Member Author

OK this looks good! Did you also run python setup.py updateplotlyjs and there were no additional files changed?

I still have all those small formatting changes, but that's it.

@nicolaskruchten nicolaskruchten merged commit efe6338 into master Feb 21, 2023
@nicolaskruchten
Copy link
Contributor

OK, thanks! Strange about the formatting changes...

can you please redo your other PR that bumps Plotly.js, on top of this one? I think there's an even newer Plotly.js patch than your last PR... sorry for the delay here :)

@archmoj archmoj deleted the update-codegen branch March 22, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants