feat(deps): replace recompose with inlined version
#1494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6eab54e:
|
G-Rath
force-pushed
the
inline-recompose
branch
2 times, most recently
from
d61a01e to
91fe633
Compare
wyze
suggested changes
Apr 25, 2021
|
Also, lets add this to L17 in |
G-Rath
force-pushed
the
inline-recompose
branch
from
91fe633 to
6eab54e
Compare
wyze
changed the title
recompose with inlined versionrecompose with inlined version
|
Thank you so much @G-Rath! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here there be dragons.
This is a first pass at inlining
recompose- it should be working, but I expect to have to iron out a few issues with tooling.I've done it in TypeScript using the types from
@types/recompose, but have not bothered to make it completely typesafe as that's pretty much impossible - ideally it'd be worth moving off these functions down the line.I've also copied over all of the tests from
recomposeexcept those that are usingsinon, just to avoid havingsinonas a dependency here - it should be possible to replacesinonwithjestfeatures, or add the dependency in a second pass.I think this is probably already good to go almost as is - I'd like to get this landed asap so that I can start using
@nivoin my projects :)Fixes #1479
Fixes #1470