io: fix input channel EOF detection #75
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When attempting to use parallel mode along with sudo, fabric was causing paramiko-ng to go into an infinite loop. The reason was due to a combination of fabric calling sendall() along with it misdetecting EOF on the input and closing the output channel. The fix for paramiko-ng going into an infinite loop is here: ploxiln/paramiko-ng#140 This commit fixes the root cause in fabric where it (apparently) erroneously detects the input channel as being closed when it is not.
|
hmm ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to use parallel mode along with sudo, fabric was causing paramiko-ng to go into an infinite loop. The reason was due to a combination of fabric calling sendall() along with it misdetecting EOF on the input and closing the output channel. The fix for paramiko-ng going into an infinite loop is here:
ploxiln/paramiko-ng#140
This commit fixes the root cause in fabric where it (apparently) erroneously detects the input channel as being closed when it is not.